Skip to content

[code_builder] Release 4.13.0. - #2663

Merged
natebosch merged 1 commit into
dart-lang:mainfrom
davidmorgan:code-builder-release-4.13.0
Oct 13, 2026
Merged

natebosch merged 1 commit into
dart-lang:mainfrom
davidmorgan:code-builder-release-4.13.0

Conversation

@davidmorgan

Copy link
Copy Markdown
Contributor

Release for the built_collection version bump, since it blocks the built_collection release via a circular dependency :)

@davidmorgan
davidmorgan requested a review from a team as a code owner October 13, 2026 09:02

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the code_builder package from 4.13.0-wip to 4.13.0 in both CHANGELOG.md and pubspec.yaml to prepare for a stable release. There are no review comments, and I have no feedback to provide.

@natebosch natebosch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this package has rolled through google3.

@natebosch

Copy link
Copy Markdown
Member

@davidmorgan - for future publishes consider opening the PR from a branch in this repo instead of a fork...

@kevmoo - is there already a backdown to get a publish link when the comment workflow isn't running?

@kevmoo

kevmoo commented Oct 13, 2026

Copy link
Copy Markdown
Member

Yep: https://github.com/dart-lang/tools/actions/runs/38373500463

just got to dig into the action UI

@natebosch
natebosch merged commit e0c9007 into dart-lang:main Oct 13, 2026
22 checks passed
@davidmorgan

Copy link
Copy Markdown
Contributor Author

@davidmorgan - for future publishes consider opening the PR from a branch in this repo instead of a fork...

Happy to push a different button; could you elaborate please? :) how does opening from here help? Thanks.

@davidmorgan
davidmorgan deleted the code-builder-release-4.13.0 branch October 14, 2026 09:39
@kevmoo

kevmoo commented Oct 14, 2026

Copy link
Copy Markdown
Member

@davidmorgan - for future publishes consider opening the PR from a branch in this repo instead of a fork...

Happy to push a different button; could you elaborate please? :) how does opening from here help? Thanks.

We get all the nice providence info about it coming from a specific commit in a specific repo on github.

@davidmorgan

Copy link
Copy Markdown
Contributor Author

@davidmorgan - for future publishes consider opening the PR from a branch in this repo instead of a fork...

Happy to push a different button; could you elaborate please? :) how does opening from here help? Thanks.

We get all the nice providence info about it coming from a specific commit in a specific repo on github.

Neat. Is it easy to point to the right button--or is there a doc about it please? :) thanks.

@kevmoo

kevmoo commented Oct 14, 2026

Copy link
Copy Markdown
Member

@davidmorgan

Copy link
Copy Markdown
Contributor Author

https://github.com/dart-lang/tools/actions/runs/38373500463

image

Now I'm confused.

I know about that thing; it's how I publish build_runner, or something like it.

How does it relate to whether the PR is made from a fork or from a branch? Is it that having the PR from a branch makes the tag better somehow?

Sorry if I keep asking dumb questions, I have very little background knowledge on this stuff :)

@natebosch

Copy link
Copy Markdown
Member

How does it relate to whether the PR is made from a fork or from a branch? Is it that having the PR from a branch makes the tag better somehow?

Security policies treat them differently. A PR from a local branch is has higher trust because only existing maintainers can open them, so we can give actions on that PR permission to post a comment back to the repo.

This PR had no comment because we cannot give the actions that run for this PR permission to post it.

@davidmorgan

Copy link
Copy Markdown
Contributor Author

Okay, now I understood. Thank you :)

copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 17, 2026
Roll `tools_rev` to c1471db9c0fead64394eab4834d0fb640403b42a and replace
`dartdev`'s duplicate `_isRunningOnBot` implementation with
`Analytics.isBot` from `package:unified_analytics`, which ignores falsy
`CI` and `BOT` environment values (`false`, `0`, empty).

Rolling `package:unified_analytics` also defaults `Analytics.agent` to
`AiAgent.detectAgentName(Platform.environment)` for SDK tools such as
`analysis_server` and `dtd` when `agent` is omitted, and tightens
`AiAgent.cursor` detection.

tools (https://github.com/dart-lang/tools/compare/350bde5..c1471db):
  c1471db9  Fri Oct 16 09:35:21 2026 -0700  Kevin Moore  [unified_analytics] Fix Cursor agent check, default agent & add isBot (dart-lang/tools#2687)
  2d0d09a1  Fri Oct 16 15:37:59 2026 +0000  Phil Quitslund  [unified_analytics] Prepare for 8.1.0 release (dart-lang/tools#2684)
  7ea42bf6  Thu Oct 15 11:13:58 2026 -0700  Kallen Tu  Add Event.migrateEvent for the dart migrate tool. (dart-lang/tools#2682)
  4eaf46ba  Wed Oct 14 18:18:45 2026 +0000  Kevin Moore  [markdown] Fix LinkParser edge cases and BlockParser retreat loop (dart-lang/tools#2631)
  03f7124a  Wed Oct 14 11:15:00 2026 -0700  Kevin Moore  [markdown] Add tool/update_spec_tests.dart and sync GFM 0.29.0.gfm.13 spec stats (dart-lang/tools#2666)
  e0c90075  Tue Oct 13 16:16:23 2026 -0700  Morgan :)  [code_builder] publish 4.13.0 (dart-lang/tools#2663)

Fixes #64594
Fixes #64591
TEST=pkg/dartdev/test/analytics_test.dart

Change-Id: I71026772917d60df2ef144cc5527be9002f087f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/565421
Commit-Queue: Kevin Moore <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants