Repository navigation
[boring] Move package:boring to dart-lang/tools (2/4): FFI helpers from package:webcrypto - #2615
Merged
Merged
Conversation
github-actions
Bot
added
the
type-infra
mosuem
changed the title
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces significant enhancements to the package:boring library, including a new BoringArena for scoped native memory management, an opensslAllocator for memory scrubbing, and NativeHandle for GC-managed BoringSSL objects. It also adds comprehensive conformance testing against Project Wycheproof and x509-limbo. I have identified a high-severity issue in the OpenSslAllocator.allocate method where allocating zero bytes incorrectly triggers an OutOfMemoryError due to BoringSSL's behavior; this should be addressed by ensuring at least one byte is allocated for zero-length requests.
PR Health
Coverage
|
| File | Coverage |
|---|---|
| pkgs/boring/example/boring_example.dart | 💔 Not covered |
| pkgs/boring/lib/bindings.dart | 💚 71 % |
| pkgs/boring/lib/boring.dart | 💔 Not covered |
| pkgs/boring/lib/src/arena.dart | 💚 93 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/html/test/differential_test.dart |
| pkgs/html/test/dom_parsing_test.dart |
| pkgs/html/test/mxss_test.dart |
| pkgs/html/test/noah_ark_clause_limit_test.dart |
This check can be disabled by tagging the PR with skip-license-check.
Breaking changes ✔️
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| boring | Breaking | 0.4.1 | 0.4.2-wip | 0.4.2-wip | ✔️ |
This check can be disabled by tagging the PR with skip-breaking-check.
Unused Dependencies ✔️
| Package | Status |
|---|---|
| boring | ✔️ All dependencies utilized correctly. |
For details on how to fix these, see dependency_validator.
This check can be disabled by tagging the PR with skip-unused-dependencies-check.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| boring | self._SymbolAddresses | bindings/boringssl.g.dart::SymbolAddresses bindings/boringssl.g.dart::addresses |
| boring | self.__va_list_tag | bindings/boringssl.g.dart::BIO_vsnprintf::args bindings/boringssl.g.dart::OPENSSL_vasprintf::args |
| boring | self.__locale_struct | bindings/boringssl.g.dart::locale_t |
This check can be disabled by tagging the PR with skip-leaking-check.
mosuem
force-pushed
the
boring/2-helpers
branch
from
September 29, 2026 14:01
176e90e to
5610274
Compare
mosuem
marked this pull request as ready for review
September 29, 2026 16:22
mosuem
force-pushed
the
boring/2-helpers
branch
2 times, most recently
from
September 30, 2026 12:26
e3198bb to
8d56ac9
Compare
mosuem
force-pushed
the
boring/2-helpers
branch
from
September 30, 2026 12:31
8d56ac9 to
a744d9b
Compare
mosuem
force-pushed
the
boring/2-helpers
branch
2 times, most recently
from
September 30, 2026 14:14
1c19967 to
ff1ebe3
Compare
mosuem
force-pushed
the
boring/2-helpers
branch
from
September 30, 2026 14:18
ff1ebe3 to
731925b
Compare
brianquinlan
approved these changes
Oct 6, 2026
Add the helpers that make the raw bindings practical to use, adapted from package:webcrypto's FFI utilities: - lib/bindings.dart: opensslAllocator (OPENSSL_malloc and OPENSSL_free, which scrubs memory with OPENSSL_cleanse), NativeHandle with its invoke extensions, extractBoringSslError, ERR_GET_LIB and ERR_GET_REASON. - lib/src/arena.dart: BoringArena, with copyBytes, cbs(), cbb() and CBB.toBytes(). Also add the unit tests for the helpers, and the Project Wycheproof and x509-limbo conformance suites with a CI job each.
mosuem
force-pushed
the
boring/2-helpers
branch
from
October 7, 2026 09:35
731925b to
c8b3777
Compare
brianquinlan
approved these changes
Oct 8, 2026
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 13, 2026
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/5eb0f2c..e1859cf): e1859cfc Fri Oct 9 14:53:01 2026 +0200 Sarah Zakarias Link a bare prefix only when it maps to exactly one library (dart-lang/dartdoc#4295) c48f6fb9 Fri Oct 9 14:25:42 2026 +0200 Sarah Zakarias Resolve prefixes through the analyzer's PrefixElement.scopeLibraries (dart-lang/dartdoc#4294) 3a6297e2 Wed Oct 7 12:56:14 2026 +0200 Sarah Zakarias Require analyzer 14.5.0 and bump to 9.0.10 (dart-lang/dartdoc#4292) ecosystem (https://github.com/dart-lang/ecosystem/compare/16dca7a..622ef61): 622ef61 Mon Oct 12 00:23:27 2026 -0700 Kevin Moore fix(firehose): enforce -wip on published versions and tighten changelog checks (dart-lang/ecosystem#467) 5576a85 Wed Oct 7 09:29:44 2026 +0200 Moritz Support use-flutter option in groundskeeper workflow (dart-lang/ecosystem#444) http (https://github.com/dart-lang/http/compare/585d433..23f8574): 23f8574 Thu Oct 8 23:27:25 2026 +0700 Cong Bang feat(http2): configurable receive windows and frame size (dart-lang/http#1999) 18051a6 Thu Oct 8 10:39:38 2026 +0200 Moritz Enable Flutter in Groundskeeper workflow for Flutter packages (dart-lang/http#2004) native (https://github.com/dart-lang/native/compare/a2a6179..10515af): 10515afca Mon Oct 12 12:21:52 2026 +0200 Daco Harkes [native_toolchain_c] Do not pass linker flags when compiling static libraries (dart-lang/native#3731) native is held back at 10515af, before dart-lang/native#3728, because it breaks the dartdev `dart install` native assets tests. See dart-lang/native#3743. test (https://github.com/dart-lang/test/compare/d749b10..30acb69): 30acb69e Mon Oct 12 12:42:54 2026 -0700 Nate Bosch Time out browser loads just before the suite load timeout (dart-lang/test#2786) 597a0326 Mon Oct 12 12:22:53 2026 -0700 Kevin Moore Fix misplaced changelog entries and remove no-op health check (dart-lang/test#2789) 0b6efee8 Mon Oct 12 12:16:29 2026 -0700 Nate Bosch [checks] Collapse nested subjects in condition descriptions (dart-lang/test#2784) 17c98493 Mon Oct 12 12:08:23 2026 -0700 Nate Bosch Follow symlinks in precompiled browser test directories (dart-lang/test#2787) 1cc813ec Fri Oct 9 11:59:56 2026 -0700 Nate Bosch [checks] Join nested collapsed subjects with "that" (dart-lang/test#2783) ada7b950 Thu Oct 8 12:03:42 2026 -0700 Nate Bosch Prepare to publish (dart-lang/test#2780) c4b165b3 Wed Oct 7 11:29:08 2026 -0700 Kevin Moore [checks] Require package:meta ^1.17.0 (dart-lang/test#2779) 4a363d70 Tue Oct 6 10:46:31 2026 -0700 Nate Bosch Let Chrome choose its remote debugging port (dart-lang/test#2778) 465d66ab Tue Oct 6 09:35:22 2026 -0700 Nate Bosch Keep Chrome stderr in the browser output when debugging (dart-lang/test#2777) tools (https://github.com/dart-lang/tools/compare/a66d517..2b54c71): 2b54c71af Mon Oct 12 10:16:45 2026 +0200 dart-ecosystem-bot[bot] [boring] Update BoringSSL to 3fed4f20 (dart-lang/tools#2655) 2337f995a Sat Oct 10 03:11:40 2026 +0300 Hasan Armoush [json_rpc_2] Add strictProtocolChecks parameter to Client (dart-lang/tools#2555) c65c69ed1 Fri Oct 9 08:54:25 2026 +0200 Moritz [boring] Move package:boring to dart-lang/tools (2/4): FFI helpers from package:webcrypto (dart-lang/tools#2615) a04e45491 Thu Oct 8 21:07:18 2026 -0700 Kevin Moore chore: wire package:api_summary and package:string_scanner PR auto-labeler (dart-lang/tools#2652) 8bdd4b92c Thu Oct 8 09:20:48 2026 +0200 Morgan :) [code_builder] Allow built_collection 6.x. (dart-lang/tools#2645) c16040d35 Wed Oct 7 17:30:08 2026 -0700 Kevin Moore [api_summary] Sort primary barrel first and experimental entry points last (v1.2.0) (dart-lang/tools#2619) b2d0780db Wed Oct 7 11:27:16 2026 -0700 Kevin Moore [stream_channel] Require package:async ^2.6.0 (dart-lang/tools#2644) 3ab7bf9d0 Wed Oct 7 11:35:27 2026 +0200 Moritz [boring] Move package:boring to dart-lang/tools (1/4): vendored BoringSSL, bindings and source build (dart-lang/tools#2614) 29df6348b Tue Oct 6 15:21:44 2026 -0700 Kevin Moore feat(coverage): support web coverage reports in test_with_coverage (dart-lang/tools#2448) Regenerate pkg/{analyzer,analyzer_plugin,analyzer_testing}/api.txt. The rolled package:api_summary v1.2.0 (dart-lang/tools#2619) sorts the primary barrel first and other entry points after it, so entries in these files are reordered. The APIs themselves are unchanged. Change-Id: Ie8ff19c5a981ea8ecee8939c75457986a947e0a7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/563220 Reviewed-by: Samuel Rawlins <[email protected]> Auto-Submit: Nate Bosch <[email protected]> Reviewed-by: Paul Berry <[email protected]> Commit-Queue: Paul Berry <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 4 of moving package:boring to dart-lang/tools. For an overview, see #2614.
Adds the helpers that make the raw bindings practical to use. They're adapted from package:webcrypto's FFI utilities:
lib/bindings.dart:opensslAllocator, backed byOPENSSL_mallocandOPENSSL_free, which scrubs memory withOPENSSL_cleanse.NativeHandle.extractBoringSslError,ERR_GET_LIB, andERR_GET_REASON.lib/src/arena.dart:BoringArena, withcopyBytes,cbs(),cbb(), andCBB.toBytes().This PR also:
example/boring_example.dartto useBoringArena.run,After this PR,
lib/has the same public API as mosuem/boringmain.Labeled
skip-changelog-check, because the helpers already shipped in 0.4.1.