Add wasm_dry_run_package event to track public package names from wasm dry run findings. by biggs0125 · Pull Request #2279 · dart-lang/tools

biggs0125 · 2025-12-12T00:41:37Z

No description provided.

…m dry run findings.

github-actions · 2025-12-12T00:42:17Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:bazel_worker	1.1.5	already published at pub.dev
package:benchmark_harness	2.4.0	already published at pub.dev
package:boolean_selector	2.1.2	already published at pub.dev
package:browser_launcher	1.1.3	already published at pub.dev
package:cli_config	0.2.1-wip	WIP (no publish necessary)
package:cli_util	0.5.0-wip	WIP (no publish necessary)
package:clock	1.1.3-wip	WIP (no publish necessary)
package:code_builder	4.11.1-wip	WIP (no publish necessary)
package:coverage	1.15.0	already published at pub.dev
package:csslib	1.0.2	already published at pub.dev
package:extension_discovery	2.1.0	already published at pub.dev
package:file	7.0.2-wip	WIP (no publish necessary)
package:file_testing	3.1.0-wip	WIP (no publish necessary)
package:glob	2.1.3	already published at pub.dev
package:graphs	2.3.3-wip	WIP (no publish necessary)
package:html	0.15.7-wip	WIP (no publish necessary)
package:io	1.1.0-wip	WIP (no publish necessary)
package:json_rpc_2	4.1.0-wip	WIP (no publish necessary)
package:markdown	7.3.1-wip	WIP (no publish necessary)
package:mime	2.1.0-wip	WIP (no publish necessary)
package:oauth2	2.0.5	already published at pub.dev
package:package_config	2.3.0-wip	WIP (no publish necessary)
package:pool	1.5.2	already published at pub.dev
package:process	5.0.5	already published at pub.dev
package:pub_semver	2.2.0	already published at pub.dev
package:pubspec_parse	1.5.1-wip	WIP (no publish necessary)
package:source_map_stack_trace	2.1.3-wip	WIP (no publish necessary)
package:source_maps	0.10.14-wip	WIP (no publish necessary)
package:source_span	1.10.1	already published at pub.dev
package:sse	4.1.8	already published at pub.dev
package:stack_trace	1.12.2-wip	(error) pubspec version (1.12.2-wip) and changelog (1.12.2-dev) don't agree
package:stream_channel	2.1.4	already published at pub.dev
package:stream_transform	2.1.2-wip	WIP (no publish necessary)
package:string_scanner	1.4.1	already published at pub.dev
package:term_glyph	1.2.3-wip	WIP (no publish necessary)
package:test_reflective_loader	0.5.0	ready to publish	`test_reflective_loader-v0.5.0`
package:timing	1.0.2	already published at pub.dev
package:unified_analytics	8.0.10	ready to publish	`unified_analytics-v8.0.10`
package:watcher	1.1.5-wip	WIP (no publish necessary)
package:yaml	3.1.3	already published at pub.dev
package:yaml_edit	2.2.3	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

gemini-code-assist

Code Review

This pull request introduces a new analytics event, flutterWasmDryRunPackage, to track detailed information from wasm dry runs, including package names and versions. The changes are consistent across the CHANGELOG.md, pubspec.yaml, and source files. A new enum and event constructor are added, along with corresponding tests. My review includes a suggestion to improve the clarity of the documentation for the new event and a note on a small redundancy in the updated test file to enhance maintainability.

gemini-code-assist · 2025-12-12T00:42:58Z

    expect(constructedEvent1.eventData.length, 2);
  });
-  test('Event.flutterWasmDryRun constructed', () {
+  test('Event.flutterWasmDryRun constructed with findings', () {


While renaming this test is a good clarification, the test body contains redundant code. Lines 473-484 are identical to the test case Event.flutterWasmDryRun constructed no findings on line 458. To avoid duplication and improve test suite clarity, consider removing the redundant part from this test and only testing the 'with findings' scenario.

github-actions · 2025-12-12T00:44:11Z

PR Health

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks

⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources
unified_analytics	Condition	survey_handler.dart::Survey::conditionList survey_handler.dart::Survey::new::conditionList
unified_analytics	PersistedSurvey	survey_handler.dart::SurveyHandler::fetchPersistedSurveys
unified_analytics	GAClient	analytics.dart::Analytics::fake::gaClient analytics.dart::AnalyticsImpl::new::gaClient
unified_analytics	UserProperty	analytics.dart::FakeAnalytics::userProperty

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes

⚠️

Package	Change	Current Version	New Version	Needed Version	Looking good?
unified_analytics	Breaking	8.0.5	8.0.10	9.0.0 Got "8.0.10" expected >= "9.0.0" (breaking changes)	⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage

⚠️

File	Coverage
pkgs/unified_analytics/lib/src/constants.dart	💔 Not covered
pkgs/unified_analytics/lib/src/enums.dart	💚 100 %
pkgs/unified_analytics/lib/src/event.dart	💚 98 % ⬆️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Add wasm_dry_run_package event to track public package names from was…

70e9f6b

…m dry run findings.

biggs0125 requested a review from kevmoo December 12, 2025 00:41

biggs0125 requested review from a team and bkonyi as code owners December 12, 2025 00:41

github-actions Bot added the package:unified_analytics label Dec 12, 2025

gemini-code-assist Bot reviewed Dec 12, 2025

View reviewed changes

Update pkgs/unified_analytics/lib/src/event.dart

3bd335c

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

bkonyi approved these changes Dec 12, 2025

View reviewed changes

biggs0125 merged commit c745428 into main Dec 12, 2025
13 checks passed

biggs0125 deleted the add-wasm-dry-run-with-packages branch December 12, 2025 23:40

kevmoo mentioned this pull request Dec 12, 2025

[web, tool] Look into public packages blocking wasm builds and reporting them in analytics flutter/flutter#178894

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add wasm_dry_run_package event to track public package names from wasm dry run findings.#2279

Add wasm_dry_run_package event to track public package names from wasm dry run findings.#2279
biggs0125 merged 2 commits into
mainfrom
add-wasm-dry-run-with-packages

biggs0125 commented Dec 12, 2025

Uh oh!

github-actions Bot commented Dec 12, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

gemini-code-assist Bot Dec 12, 2025

Uh oh!

github-actions Bot commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

biggs0125 commented Dec 12, 2025

Uh oh!

github-actions Bot commented Dec 12, 2025

Package publishing

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 12, 2025

PR Health

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants