Skip to content

Add enabledFeatures key to Analytics constructors #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliasyishak merged 4 commits into from
Dec 11, 2023
Merged

Add enabledFeatures key to Analytics constructors #217

eliasyishak merged 4 commits into from
Dec 11, 2023

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Dec 8, 2023

Closes:

The main change for this PR will add a new optional field on the Analytics constructors to allow sending a string for the enabled features.

From the example file below

final Analytics analytics = Analytics.development(
  tool: DashTool.flutterTool,
  flutterChannel: 'ey-test-channel',
  flutterVersion: 'Flutter 3.6.0-7.0.pre.47',
  clientIde: 'VSCode',
  dartVersion: 'Dart 2.19.0',
  // This can be set to true while testing to validate
  // against GA4 usage limitations (character limits, etc.)
  enableAsserts: false,
  enabledFeatures: 'feature-1,feature-2',  // <---- the newly added parameter
);

The string indicating the enabled features will be sent with every event in the user properties. This is similar to what we did before in flutter GA3 where we set the enabled features for the session.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@dart-lang dart-lang deleted a comment from github-actions bot Dec 8, 2023
@github-actions
Copy link

github-actions bot commented Dec 8, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 5.8.0 ready to publish unified_analytics-v5.8.0
package:graphs 2.3.2-wip WIP (no publish necessary)
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:cli_config 0.1.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@eliasyishak eliasyishak mentioned this pull request Dec 8, 2023
Closed
32 tasks
christopherfujino
christopherfujino reviewed Dec 8, 2023
View reviewed changes
christopherfujino
christopherfujino approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliasyishak eliasyishak merged commit 56a30ce into dart-lang:main Dec 11, 2023
@eliasyishak eliasyishak deleted the 198-track-enabled-features branch December 11, 2023 16:59
@eliasyishak eliasyishak mentioned this pull request Jan 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leighajarett leighajarett Awaiting requested review from leighajarett

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package:unified_analytics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliasyishak @christopherfujino