Skip to content

Added enum + event for timing events #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliasyishak merged 3 commits into from
Nov 26, 2023
Merged

Added enum + event for timing events #208

eliasyishak merged 3 commits into from
Nov 26, 2023

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Nov 22, 2023

Related to tracker issue:

This PR adds a general timing event that can be used by any client of package:unified_analytics. The fields in the Event constructor for this event have been designed to match what was used for the sendTiming method in flutter/flutter

  @override
  void sendTiming(
    String category,
    String variableName,
    Duration duration, {
    String? label,
  }) {
    if (suppressAnalytics) {
      return;
    }
    _analytics.sendTiming(
      variableName,
      duration.inMilliseconds,
      category: category,
      label: label,
    );
  }
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

github-actions bot commented Nov 22, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 5.6.0 ready to publish unified_analytics-v5.6.0
package:graphs 2.3.2-wip WIP (no publish necessary)
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:cli_config 0.1.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@eliasyishak eliasyishak mentioned this pull request Nov 22, 2023
Closed
32 tasks
christopherfujino
christopherfujino approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eliasyishak eliasyishak merged commit c63dcb5 into dart-lang:main Nov 26, 2023
@eliasyishak eliasyishak deleted the add-timing-enum-and-event branch November 26, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package:unified_analytics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliasyishak @christopherfujino