Add generic usage event used for iOS/macOS workflows + generic exception event
#206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
32 tasks
bkonyi
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to tracker issue:
package:unified_analyticsimplementation in flutter tool flutter/flutter#128251This PR adds 2 events here, one for the generic
UsageEventin flutter, and another for thesendExceptionmethod in flutter.For the
UsageEvent, you can refer to this sheet which shows all the call sites for that event. I found that all of these events were apple related so I consolidated them down into just one event. The event created for is calledEvent.appleUsageEventFor the
sendExceptionmethod, we are only sending the exception's runtimeType as a string from flutter, so i created theEvent.exceptionconstructor which takes just one parameter for the exception string. Because this not specific to only flutter, we can have other dash tools also use this event to track exceptions in their workflows.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.