Add terminal info to flutter command event #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasyishak
assigned
leighajarett and
eliasyishak and unassigned
eliasyishak and
leighajarett
Contributor
Author
|
@leighajarett is it actually necessary to have this field as a user property? After looking through flutter code, we are only sending this along with each command event It looks like the only two fields we send with each event is for the channel and OS, which we are currently doing now |
eliasyishak
commented
Nov 15, 2023
| eventData = { | ||
| 'commandPath': commandPath, | ||
| 'result': result, | ||
| 'commandHasTerminal': commandHasTerminal, |
Contributor
Author
There was a problem hiding this comment.
The newly added parameter
32 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to tracker issue:
package:unified_analyticsimplementation in flutter tool flutter/flutter#128251Closes:
While migrating the
Usage.commandstatic method, includes thecommandHasTerminalparameter, I realized that it probably makes sense to include it with the previously migratedCommandResultevent.This new event will now let us record which flutter command was run, while also keeping track of whether the invocation included a terminal.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.