New enum + constructor added for nullSafetyMigrationResult
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
bwilkerson
reviewed
Nov 14, 2023
eliasyishak
changed the title
nullSafetyAnalysisResultnullSafetyMigrationResult
Contributor
|
I actually don't think we need this event anymore. I deleted this event in https://github.com/flutter/flutter/pull/123031/files#diff-aee5c7b97c66ed433071dcf682d8643bf6341749f7b14616227f136373dc7363L257, however that got reverted only because we still support non-null-safe code internally. |
Contributor
Author
Sounds good, I'll make a note that we are deprecating this event in the tracker issue and close |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to tracker issue:
package:unified_analyticsimplementation in flutter tool flutter/flutter#128251This event is for the
NullSafetyAnalysisEventclass.This event has a more involved
sendmethod that actually sends 3 separate events. I have taken those 3 separate events and consolidated them down to just one event with 4 parameters included.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.