Skip to content

Add enum + event constructor for code size analysis #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliasyishak merged 3 commits into from
Nov 13, 2023
Merged

Add enum + event constructor for code size analysis #200

eliasyishak merged 3 commits into from
Nov 13, 2023

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Nov 10, 2023

Related to tracker issue:

This migrates the CodeSizeEvent event, which is defined here and below

/// An event that reports when the code size measurement is run via `--analyze-size`.
class CodeSizeEvent extends UsageEvent {
  CodeSizeEvent(String platform, {
    required Usage flutterUsage,
  }) : super(
    'code-size-analysis',
    platform,
    flutterUsage: flutterUsage
  );
}

There is only one reference of this class getting called within the flutter tool code base and it is within flutter_tools/lib/src/base/analyze_size.dart

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

github-actions bot commented Nov 10, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 5.4.0 ready to publish unified_analytics-v5.4.0
package:graphs 2.3.2-wip WIP (no publish necessary)
package:cli_config 0.1.2 already published at pub.dev
package:extension_discovery 2.0.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@eliasyishak eliasyishak mentioned this pull request Nov 10, 2023
Closed
32 tasks
christopherfujino
christopherfujino reviewed Nov 10, 2023
View reviewed changes
christopherfujino
christopherfujino approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliasyishak eliasyishak merged commit 68b4e6b into dart-lang:main Nov 13, 2023
@eliasyishak eliasyishak deleted the add-code-size-event branch November 13, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package:unified_analytics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliasyishak @christopherfujino @kenzieschmoll