Skip to content

Conversation

@eliasyishak
Copy link
Contributor

Related to issue:

Migrating the BuildEvent from package:usage to package:unified_analytics

Snippet of the code for BuildEvent

class BuildEvent extends UsageEvent {
  BuildEvent(String label, {
    String? command,
    String? settings,
    String? eventError,
    required Usage flutterUsage,
    required String type,
  }) : _command = command,
  _settings = settings,
  _eventError = eventError,
      super(
    // category
    'build',
    // parameter
    type,
    label: label,
    flutterUsage: flutterUsage,
  );

  final String? _command;
  final String? _settings;
  final String? _eventError;

  @override
  void send() {
    final CustomDimensions parameters = CustomDimensions(
      buildEventCommand: _command,
      buildEventSettings: _settings,
      buildEventError: _eventError,
    );
    flutterUsage.sendEvent(
      category,
      parameter,
      label: label,
      parameters: parameters,
    );
  }
}

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@eliasyishak eliasyishak removed their assignment Oct 27, 2023
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 5.1.0 ready to publish unified_analytics-v5.1.0
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:cli_config 0.1.2 already published at pub.dev
package:graphs 2.3.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliasyishak eliasyishak merged commit 5daf7bc into dart-lang:main Oct 31, 2023
@eliasyishak eliasyishak deleted the add-build-events-for-flutter branch October 31, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants