test coverage doesn't "pick-up" some test #479

Activity

1. iapicca

   closed this as completedon May 10, 2021
2. iapicca

   reopened this on May 11, 2021
3. iapicca commented on May 11, 2021

   

   iapicca

   on May 11, 2021

   Last edited by iapicca

   Author

   More actions

   update

   while somehow the issue disappeared "duplicating" the test for the (dart) package above
   I'm experiencing the same problem with another package (from quite some time)
   even if in a larger package the code is very much self contained and I feel that might
   be consider a useful code sample

   here is the ui-output of the coverage screenshot from the same commands of the partial code sample above

   anyhow
   this is the code

   code (at the time of writing)

   import 'package:flutter/material.dart';
   import 'package:yak_runner/yak_runner.dart';
   
   import '../../yak_widgets.dart';
   
   /// a widget that provides a `loading screen`
   class Initializer extends StatelessWidget {
     /// allows a `const` constuctor
     const Initializer({
       required this.loadingScreen,
       required this.progressState,
       required this.onCompleted,
       required this.onFailed,
       Key key = const ValueKey('Initializer'),
     }) :
           // coverage:ignore-line
           super(key: key);
   
     /// requires a `loadingScreen`
     final FractionalIndexItemBuilder loadingScreen;
   
     /// provides the state of the loading
     final ValueNotifier<Result<double>> progressState;
   
     /// provides the screen when loading is completed
     final WidgetBuilder onCompleted;
   
     /// provides the screen when loading has failed
     final WidgetBuilder onFailed;
   
     @override
     Widget build(BuildContext context) {
       return ValueListenableBuilder<Result<double>>(
         key: ValueKey('ValueListenableBuilder@$key'),
         valueListenable: progressState,
         builder: (context, value, _) {
           return value is Success
               ? (value as Success).data < 1
                   ? loadingScreen(context, (value as Success).data)
                   : onCompleted(context)
               : onFailed(context);
         },
       );
     }
   }
   

   and this is the test

   test (at the time of writing)

   import 'package:flutter/material.dart';
   import 'package:flutter_test/flutter_test.dart';
   import 'package:yak_error_handler/yak_error_handler.dart';
   import 'package:yak_runner/yak_runner.dart';
   import 'package:yak_widgets/yak_widgets.dart';
   
   void main() {
     final progress = ValueNotifier<Result<double>>(Success(.0));
     final loading = UniqueKey();
     final failed = UniqueKey();
     final completed = UniqueKey();
   
     final app = MaterialApp(
       home: Material(
         child: Initializer(
           loadingScreen: (context, progress) => Container(key: loading),
           progressState: progress,
           onCompleted: (context) => Container(key: completed),
           onFailed: (context) => Container(key: failed),
         ),
       ),
     );
     group('`Initializer` test', () {
       testWidgets(
           'WHEN progress is Success & < 1 THEN `loadingScreen` is VISIBLE',
           (tester) async {
         await tester.pumpWidget(app);
   
         expect(
           find.byKey(loading),
           findsOneWidget,
           reason: ' `loadingScreen` should be VISIBLE',
         );
         expect(
           find.byKey(completed),
           findsNothing,
           reason: ' `onCompleted` should NOT be VISIBLE',
         );
         expect(
           find.byKey(failed),
           findsNothing,
           reason: ' `onFailed` should NOT be VISIBLE',
         );
       });
   
       testWidgets(
           'WHEN progress is Success & >= 1 ' 'THEN `onCompleted` is VISIBLE',
           (tester) async {
         await tester.pumpWidget(app);
         progress.value = Success(1);
         await tester.pumpAndSettle(kThemeAnimationDuration);
   
         expect(
           find.byKey(loading),
           findsNothing,
           reason: ' `loadingScreen` should NOT be VISIBLE',
         );
         expect(
           find.byKey(completed),
           findsOneWidget,
           reason: ' `onCompleted` should be VISIBLE',
         );
   
         expect(
           find.byKey(failed),
           findsNothing,
           reason: ' `onFailed` should NOT be VISIBLE',
         );
       });
   
       testWidgets('WHEN progress is `Failure` ' 'THEN `onFailed` is VISIBLE',
           (tester) async {
         await tester.pumpWidget(app);
         progress.value = Failure<double>(ErrorReport());
         await tester.pumpAndSettle(kThemeAnimationDuration);
   
         expect(
           find.byKey(loading),
           findsNothing,
           reason: ' `loadingScreen` should NOT be VISIBLE',
         );
         expect(
           find.byKey(completed),
           findsNothing,
           reason: ' `onCompleted` should NOT be VISIBLE',
         );
   
         expect(
           find.byKey(failed),
           findsOneWidget,
           reason: ' `onFailed` should  be VISIBLE',
         );
       });
     });
   }
   

   those are both uninteresting and my set up works just fine for the other widgets.

   I wish I could be more helpful,
   can you please suggest a way to reproduce the problem?
4. natebosch commented on May 12, 2021

   

   natebosch

   on May 12, 2021

   Member

   More actions

   can you try renaming the test so that it ends in _test.dart?
5. iapicca commented on May 12, 2021

   

   iapicca

   on May 12, 2021

   Author

   More actions

   ... facepalm
   my bad
6. iapicca

   closed this as completedon May 12, 2021
7. mosuem

   transferred this issue fromdart-archive/coverageon Aug 28, 2024
8. mosuem

   added

   package:coverage

   on Aug 28, 2024