json_rpc_2: Add strictProtocolChecks parameter to Client

Server and Peer classes have the strictProtocolChecks parameter that allows to skip the check for "jsonrpc":"2.0" field in requests:

tools/pkgs/json_rpc_2/lib/src/server.dart

Lines 251 to 264 in 338a2c8

    
           if (strictProtocolChecks && !request.containsKey('jsonrpc')) { 
        
             throw RpcException( 
        
                 error_code.INVALID_REQUEST, 
        
                 'Request must ' 
        
                 'contain a "jsonrpc" key.'); 
        
           } 
        
           if ((strictProtocolChecks || request.containsKey('jsonrpc')) && 
        
               request['jsonrpc'] != '2.0') { 
        
             throw RpcException( 
        
                 error_code.INVALID_REQUEST, 
        
                 'Invalid JSON-RPC ' 
        
                 'version ${jsonEncode(request['jsonrpc'])}, expected "2.0".'); 
        
           }

But for Client there's no way to skip that check in a response:

tools/pkgs/json_rpc_2/lib/src/client.dart

Lines 228 to 230 in 338a2c8

    
             bool _isResponseValid(Object? response) { 
        
               if (response is! Map) return false; 
        
               if (response['jsonrpc'] != '2.0') return false;

For context, I'm trying to get it working with mjson C library which doesn't add this field in its responses.

[json_rpc_2] Add strictProtocolChecks parameter to Client (dart-lang#…

Navigation Menu

Repository navigation

json_rpc_2: Add strictProtocolChecks parameter to Client #2422

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (strictProtocolChecks && !request.containsKey('jsonrpc')) {
	throw RpcException(
	error_code.INVALID_REQUEST,
	'Request must '
	'contain a "jsonrpc" key.');
	}

	if ((strictProtocolChecks \|\| request.containsKey('jsonrpc')) &&
	request['jsonrpc'] != '2.0') {
	throw RpcException(
	error_code.INVALID_REQUEST,
	'Invalid JSON-RPC '
	'version ${jsonEncode(request['jsonrpc'])}, expected "2.0".');
	}

	bool _isResponseValid(Object? response) {
	if (response is! Map) return false;
	if (response['jsonrpc'] != '2.0') return false;

json_rpc_2: Add strictProtocolChecks parameter to Client #2422

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions