Skip to content

Fix package:watcher performance when there are multiple symlink cycles #2170

Closed

Description

@davidmorgan

Currently the behavior with symlinks is undefined + untested.

Add test coverage, decide the new behavior, do a breaking release.

As part of this change, fix behavior when there are cyclic symlinks #1728

Activity

  1. self-assigned this
    on Sep 26, 2025
  2. davidmorgan commented on Sep 29, 2025

    @davidmorgan
    ContributorAuthor

    I started by looking at the file watcher. It turns out there is already some awkward/inconsistent behavior before looking at symlinks, so I will tackle that first.

  3. davidmorgan commented on Nov 3, 2025

    @davidmorgan
    ContributorAuthor

    It looks like rather than do a big breaking release we'll do a bug fix release that addresses just the bad behavior when there are loops, see linked PR.

  4. changed the title [-]Breaking package:watcher change for behavior with symlinks[/-] [+]Fix package:watcher performance when there are multiple symlink cycles[/+] on Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions