Repository navigation
Allow omitting parentheses for Expression.asA(Expression other) #1140
Description
Expression.asA(Expression other) always wraps the code into parentheses. While this is a good default it is not always necessary. The problem for me is that the generated code triggers the linter rule unnecessary_parenthesis in our CI. Unfortunately dart_style auto fixes does not support the removal of unnecessary parenthesis.
My suggestion would be to have an optional parameter.
the following:
becomes
Expression asA(Expression other, { bool parenthesized = true }) {
final exp = BinaryExpression._( expression, other, 'as'));
return parenthesized
? ParenthesizedExpression._(exp)
: exp
}
Activity
natebosch commentedon Nov 9, 2023
We typically recommend avoiding that type of style lint for generated code. As mentioned in #828 readability is not a goal for the generated output from this package. This is a relatively easy change though, and most of the complexity stays in the calling code deciding what value to pass.
@srawlins do you have any opinions on adding this option?
srawlins commentedon Nov 9, 2023
Yeah I think that supporting a
parenthesizedparameter everywhere (it's not justasAright?) would add a fair amount of complexity.I recommend using
// ignore_for_file: type=lintfor generated files. See https://dart.dev/tools/analysis#suppressing-rules-for-a-file.refactor: migrate TypeHelpers to code_builder AST expressions
refactor(json_serializable): migrate codegen to `code_builder` AST (#…