Skip to content

Commit 3380098

Browse files
authored
Add sanity check for targetPackage name in package:extension_discovery (#2535)
1 parent 0759473 commit 3380098

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

‎pkgs/extension_discovery/lib/extension_discovery.dart‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ import 'src/yaml_config_format.dart';
1616

1717
export 'src/package_config.dart' show PackageConfigException, findPackageConfig;
1818

19+
final _invalidTargetPackageChars = RegExp(r'[\\/<>:"|?*]');
20+
1921
/// Information about an extension for target package.
2022
final class Extension {
2123
/// Name of the package providing an extension.
@@ -129,6 +131,18 @@ Future<List<Extension>> findExtensions(
129131
bool useCache = true,
130132
Uri? packageConfig,
131133
}) async {
134+
// Sanity check targetPackage
135+
if (targetPackage.trim().isEmpty ||
136+
targetPackage == '..' ||
137+
targetPackage == '.' ||
138+
targetPackage.contains(_invalidTargetPackageChars)) {
139+
throw ArgumentError.value(
140+
targetPackage,
141+
'targetPackage',
142+
'Must be a valid package name',
143+
);
144+
}
145+
132146
packageConfig ??= await Isolate.packageConfig;
133147
if (packageConfig == null) {
134148
throw UnsupportedError(

0 commit comments

Comments
 (0)