Repository navigation
Commit 0a2c07a
committed
fix(coverage): changelog entry, more root tests, revert lint form
Adds a changelog entry for the file: containment fix.
Adds tests covering the other roots _isWithinKnownRoots checks: sdkRoot,
a known package root from package_config.json, and the current directory.
Only packagePath had a positive test before.
Reverts the null-aware ?packagePath/?sdkRoot elements back from the
if (x != null) x form requested in an earlier review comment. CI runs
dart analyze --fatal-infos, and this package's own lints recommend the
null-aware form (use_null_aware_elements), so the if form was failing
analyze in CI even though it type-checks fine locally without the flag.1 parent 64d1382 commit 0a2c07a
3 files changed
Lines changed: 42 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
9 | 14 | | |
10 | 15 | | |
11 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
123 | | - | |
| 122 | + | |
| 123 | + | |
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
145 | 180 | | |
146 | 181 | | |
147 | 182 | | |
| |||
0 commit comments