Repository navigation
Commit 068119b
authored
[pubspec_parse] Support tag_pattern for git dependencies (#2565)
Add support for the `tag_pattern` key on git dependencies, introduced
in Dart 3.9. See https://dart.dev/tools/pub/dependencies#git-packages
- Add nullable `tagPattern` and `version` fields to `GitDependency`.
The existing constructor is unchanged, and `GitDependency.fromData`
gains only an optional named `version` parameter.
- Parse the `version` key next to a `git` source into
`GitDependency.version` instead of silently dropping it, matching
the pub client, which reads the constraint for every source. An
invalid constraint is now reported as a parse error.
- Validate `tag_pattern` the same way as the pub client: it must
contain a single `{{version}}` marker and cannot be combined with
`ref`. Errors point at the `tag_pattern` key. As with the rest of
this package, nothing is gated on the language version, so
`tag_pattern` parses under an SDK constraint older than 3.9 even
though pub rejects it.
- Include `tag_pattern` and `version` in `GitDependency.toJson` when
present so that `Pubspec.toJson` round-trips.
- Add tests for parsing, validation errors, and `toJson`
round-tripping. Parsing tests are cross-checked against the pub
client like the rest of the suite.
Fixes #21551 parent 7d859ed commit 068119b
6 files changed
Lines changed: 252 additions & 14 deletions
File tree
- pkgs/pubspec_parse
- lib/src
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
85 | 88 | | |
86 | 89 | | |
87 | 90 | | |
| |||
131 | 134 | | |
132 | 135 | | |
133 | 136 | | |
134 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
135 | 153 | | |
136 | | - | |
| 154 | + | |
137 | 155 | | |
138 | 156 | | |
139 | 157 | | |
140 | 158 | | |
141 | 159 | | |
142 | | - | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
143 | 169 | | |
144 | 170 | | |
145 | 171 | | |
146 | 172 | | |
147 | 173 | | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
148 | 197 | | |
149 | 198 | | |
150 | 199 | | |
151 | 200 | | |
152 | 201 | | |
153 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
154 | 205 | | |
155 | 206 | | |
156 | | - | |
| 207 | + | |
157 | 208 | | |
158 | 209 | | |
159 | 210 | | |
160 | 211 | | |
161 | 212 | | |
162 | 213 | | |
163 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
164 | 221 | | |
165 | 222 | | |
166 | 223 | | |
| 224 | + | |
| 225 | + | |
167 | 226 | | |
168 | 227 | | |
169 | 228 | | |
| |||
306 | 365 | | |
307 | 366 | | |
308 | 367 | | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
13 | 18 | | |
14 | 19 | | |
15 | 20 | | |
| |||
247 | 252 | | |
248 | 253 | | |
249 | 254 | | |
250 | | - | |
| 255 | + | |
251 | 256 | | |
252 | 257 | | |
253 | 258 | | |
| |||
256 | 261 | | |
257 | 262 | | |
258 | 263 | | |
| 264 | + | |
| 265 | + | |
259 | 266 | | |
260 | 267 | | |
261 | 268 | | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
262 | 300 | | |
263 | 301 | | |
264 | 302 | | |
| |||
292 | 330 | | |
293 | 331 | | |
294 | 332 | | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
295 | 352 | | |
296 | 353 | | |
297 | 354 | | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
298 | 423 | | |
299 | 424 | | |
300 | 425 | | |
| |||
399 | 524 | | |
400 | 525 | | |
401 | 526 | | |
402 | | - | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
403 | 532 | | |
404 | 533 | | |
| 534 | + | |
405 | 535 | | |
406 | 536 | | |
407 | 537 | | |
408 | 538 | | |
409 | | - | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
410 | 544 | | |
411 | 545 | | |
| 546 | + | |
412 | 547 | | |
413 | 548 | | |
414 | 549 | | |
415 | 550 | | |
416 | 551 | | |
417 | 552 | | |
418 | 553 | | |
| 554 | + | |
419 | 555 | | |
420 | 556 | | |
421 | 557 | | |
| 558 | + | |
422 | 559 | | |
423 | 560 | | |
424 | 561 | | |
| |||
0 commit comments