Repository navigation
Conversation
Towards #994, #2671, #2742 The `prints` Matcher is not quite orthogonal to other expectations that might be checked on a callback (#994). The `expectAsync` pattern doesn't fit cleanly into the `package:checks` patterns. Solve both of these problems by implementing a separate, non-test specific package which can "specate" on executing Dart code and record details about the interactions. The records can then be checked with typical expectation extensions. TAG=agy CONV=3f8ca85a-8236-4bd5-b7a1-26d64a8fb70a
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
github-actions
Bot
added
the
type-infra
Member
|
I like the idea of "Spy" - we can use 🥷 emjoi or something! |
TAG=agy CONV=3f8ca85a-8236-4bd5-b7a1-26d64a8fb70a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #994, #2671, #2742
The
printsMatcher is not quite orthogonal to other expectations thatmight be checked on a callback (#994).
The
expectAsyncpattern doesn't fit cleanly into thepackage:checkspatterns.
Solve both of these problems by implementing a separate, non-test
specific package which can "specate" on executing Dart code and record
details about the interactions. The records can then be checked with
typical expectation extensions.
TAG=agy
CONV=3f8ca85a-8236-4bd5-b7a1-26d64a8fb70a