Skip to content

Remove redundant tag - #2738

Merged
natebosch merged 2 commits into
masterfrom
drop-vm-tag
Aug 28, 2026
Merged

natebosch merged 2 commits into
masterfrom
drop-vm-tag

Conversation

@natebosch

Copy link
Copy Markdown
Member

This tag was added along with support for VM debugging, but it was
always redundant and likely introduced because of confusion over whether
it would impact whether this test case runs for VM tests. There is no
configuration in dart_test.yaml associated with this tag.

Removes a warning to make the test output be more fully grouped in the
github reporter output.

This tag was added along with support for VM debugging, but it was
always redundant and likely introduced because of confusion over whether
it would impact whether this test case runs for VM tests. There is no
configuration in `dart_test.yaml` associated with this tag.

Removes a warning to make the test output be more fully grouped in the
github reporter output.
@natebosch
natebosch requested a review from a team as a code owner August 27, 2026 23:36
@natebosch
natebosch requested a review from kevmoo August 27, 2026 23:36
@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

PR Health

@kevmoo kevmoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but CI is sad

@natebosch

Copy link
Copy Markdown
Member Author

CI is sad

We've picked up some flakes recently 😢

@natebosch
natebosch merged commit b575eda into master Aug 28, 2026
117 of 118 checks passed
@natebosch
natebosch deleted the drop-vm-tag branch August 28, 2026 00:16
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 4, 2026
Revisions updated by `dart tools/rev_sdk_deps.dart test`.

test (https://github.com/dart-lang/test/compare/55b186d..18ef597):
  18ef5978  Fri Sep 4 10:13:39 2026 -0700  Nate Bosch  Add support for collapsed error messages (dart-lang/test#2651)
  6783445c  Wed Sep 2 16:46:04 2026 -0700  Nate Bosch  Prepare to publish (dart-lang/test#2737)
  8de693e1  Tue Sep 1 03:54:15 2026 +0000  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/test#2744)
  575e4dad  Mon Aug 31 17:01:46 2026 -0700  Nate Bosch  Fix deadlock waiting on serverSocket (dart-lang/test#2740)
  bd9acf32  Thu Aug 27 22:53:54 2026 -0700  Nate Bosch  Unskip a test on windows (dart-lang/test#2741)
  b575eda9  Thu Aug 27 17:16:16 2026 -0700  Nate Bosch  Remove redundant tag (dart-lang/test#2738)
  d21b06cb  Thu Aug 27 16:38:17 2026 -0700  dependabot[bot]  Bump the github-actions group across 1 directory with 5 updates (dart-lang/test#2709)
  773bc56c  Thu Aug 27 16:11:00 2026 -0700  Nate Bosch  Use read permissions in test_descriptor and test_process workflows (dart-lang/test#2736)
  73e85f1b  Wed Aug 26 06:36:41 2026 +0700  herdiyanitdev  Precompiled browser tests: stop serving files from outside the precompiled root (dart-lang/test#2724)
  bbe8f9bf  Tue Aug 18 09:02:24 2026 -0700  Kevin Moore  Export TestFailure from package:test_api/scaffolding.dart (dart-lang/test#2723)

TAG=agy
CONV=e6fd1c32-ded3-443f-83e5-2e15b4ffaccb
[email protected]

Change-Id: Iabc67d46c413470f0d2e5341e719d4edf702a94b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/546020
Commit-Queue: Nate Bosch <[email protected]>
Auto-Submit: Nate Bosch <[email protected]>
Reviewed-by: Kevin Moore <[email protected]>
Commit-Queue: Kevin Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants