You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reacted by Felix Angelov, Moses Karunia, Taha Tesser, Stanislav Bondarenko, Mike, Vladimir Markov, Vlad Bondarenko, Kevin Suhajda, Chris Raastad and Kyohei Ito
I dug into this today. I found a fix but I don't know why. Basically coverage works to completion but the test process doesn't always exit. Note testing and coverage collection always works but just exiting is flaky. This is resolved if we add a force: truehere. We probably didn't catch this in CI because we force exit due to similar issues here.
@grouma for me it always hangs after all tests were run and does not end.
Both on my dev machine and on the build runner (using the google dart docker image).
I'm not able to reproduce this with pub run test --coverage=coverage. I am however able to reproduce this with dart test --coverage=coverage. @bkonyi can you take a look?
@grouma@bkonyi@jakemac53 I can also confirm that pub run build_runner test --file-reporter json:foo/test-results.json passes in certain situations for us at Workiva, while the exact same test suite hangs when running dart run build_runner test --file-reporter json:foo/test-results.json. This is on Dart 2.13.0.
Even when it doesn't hang completely - running dart run build_runner test with a file-reporter takes 4-5 times longer than it does when not using a file-reporter, whereas pub run build_runner test with a file-reporter takes only about 2 times as long.
Activity
mit-mit commentedon Feb 3, 2021
cc @jakemac53 @natebosch
helinanever commentedon Mar 10, 2021
@mit-mit This is still an issue. Many pub.green builds time out due to this (e.g. around 200 builds tested with Flutter 2.0.1).
jakemac53 commentedon Mar 10, 2021
I can't repro this for vm tests but I can repro it for web tests (tried in the glob package), cc @grouma
grouma commentedon Mar 11, 2021
I dug into this today. I found a fix but I don't know why. Basically coverage works to completion but the test process doesn't always exit. Note testing and coverage collection always works but just exiting is flaky. This is resolved if we add a
force: truehere. We probably didn't catch this in CI because we force exit due to similar issues here.cc @natebosch for thoughts on what's going on
traveling-developer commentedon Mar 18, 2021
@grouma this is still an issue. Using dart 2.12.2 and test 1.16.8
If I run
dart test --coverage="coverage"it never endsgrouma commentedon Mar 18, 2021
@yudansha is it flaky or does it alway fail?
traveling-developer commentedon Mar 18, 2021
@grouma for me it always hangs after all tests were run and does not end.
Both on my dev machine and on the build runner (using the google dart docker image).
grouma commentedon Mar 19, 2021
I'm not able to reproduce this with
pub run test --coverage=coverage. I am however able to reproduce this withdart test --coverage=coverage. @bkonyi can you take a look?aaronlademann-wf commentedon Jun 9, 2021
@grouma @bkonyi @jakemac53 I can also confirm that
pub run build_runner test --file-reporter json:foo/test-results.jsonpasses in certain situations for us at Workiva, while the exact same test suite hangs when runningdart run build_runner test --file-reporter json:foo/test-results.json. This is on Dart 2.13.0.Even when it doesn't hang completely - running
dart run build_runner testwith a file-reporter takes 4-5 times longer than it does when not using a file-reporter, whereaspub run build_runner testwith a file-reporter takes only about 2 times as long.Use pub to execute tests