Repository navigation
Make linter rule search smarter - #7539
Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances the linter rules search functionality by allowing users to search rules by both name and description. It introduces a new lintMatchesQuery utility function that performs case-insensitive matching and treats spaces in the query as underscores when matching rule names, alongside corresponding UI updates and tests. Feedback suggests optimizing lintMatchesQuery by reusing an existing _whitespacePattern regular expression instead of recompiling a new RegExp on every invocation to avoid unnecessary overhead during search filtering.
|
Visit the preview URL for this PR (updated for commit 4784ee1): |
|
/gcbrun |
|
Thanks for the PR @khanak0509! I will try to take a look today or tomorrow. No need to update with |
parlough
left a comment
There was a problem hiding this comment.
I pushed some small clean up but otherwise looks good to me. Thanks for tackling this and for being patient!
|
Thanks |
Linter rules search used to need an exact name match. Now spaces count as _ , and it also searches the description text.
Fixes #7504
Results before change:
Results after change: