Repository navigation
Document that Request.ifModifiedSince throws FormatException - #129
Merged
Merged
Conversation
kevmoo
approved these changes
Feb 25, 2020
Member
|
Cleary an oversight. To throw "at some higher level" you'd almost want to parse these, if found, during the request creation. Honestly, you could do that now – it could be a feature of the |
natebosch
approved these changes
Feb 25, 2020
Member
Author
That might be nice to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit surprising that
Request.ifModifiedSincethrowsFormatExceptionif the incoming request is invalid.We could also return
null. But this has the downside of building a server that accepts invalid requests. The problem with accepting invalid requests is that you're going to break your users if you fix such a bug later.Ideally, we should throw an exception that is caught and converted to
400at some higher level.But this would be a new way of structuring apps in
shelf, so we should probably consider this in detail before we jump on the idea.