Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jan 10, 2024

Adds the rest of the packages we are actively using dart fix in:

Related to flutter/flutter#139249


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

Adds the rest of the package we are actively using dart fix in:

- flutter_test
- integration_test
- flutter_driver
  - pending flutter/flutter#141300
@copybara-service
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/345583

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@copybara-service
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/345584

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@Piinks
Copy link
Contributor Author

Piinks commented Jan 10, 2024

This project uses Gerrit for code reviews.

I knew that. Silly me I forgot. 😜

This copybara service is awesome!

@parlough
Copy link
Member

parlough commented Jan 10, 2024

This copybara service is awesome!

Except it opened two duplicate CLs for you :P

The copybara really wanted to do some extra copying today.

copybara-service bot pushed a commit that referenced this pull request Jan 11, 2024
This reverts commit 28e0ae5.

Reason for revert: There is a typo and the script is failing.

Original change's description:
> Update analyze_flutter_flutter.sh
>
> Closes #54576
>
> GitOrigin-RevId: bd0e192
> Change-Id: I14f1d25d059e618674d73a27dcf5054aff40fe2b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345584
> Commit-Queue: Slava Egorov <[email protected]>
> Reviewed-by: Slava Egorov <[email protected]>

Change-Id: I38aba29de70a7bb81444e937644d18645b1a74ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345740
Reviewed-by: Slava Egorov <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Slava Egorov <[email protected]>
Auto-Submit: Kate Lovett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants