You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[dartdev] Share package:unified_analytics isBot check and fix CI=false #64594
_isRunningOnBot in pkg/dartdev maintains a manual copy of flutter_tools's BotDetector and checks env.containsKey('CI') and env.containsKey('BOT'), which treats CI=false, CI=0, and BOT=0 as CI bots.
Root cause: pkg/dartdev/lib/src/unified_analytics.dart#L222-L231 checks key presence (env.containsKey('CI') and env.containsKey('BOT') after only excluding env['BOT'] == 'false'), and its comment at #L203-L206 notes that the list must be manually synced with flutter_tools.
Impact: Developers or scripts that set CI=false, CI=0, or BOT=0 locally have dart CLI analytics suppressed as bots, and bot-detection rules drift between dartdev and flutter_tools.
Proposed Fix
Fix CI and BOT checks in pkg/dartdev/lib/src/unified_analytics.dart#L207-L255 to require non-empty values other than 'false' and '0' (including treating BOT=0 as an explicit non-bot override alongside BOT=false at #L210), and replace _isRunningOnBot with the shared package:unified_analytics bot detector (dart-lang/tools#2672) once rolled into the SDK.
Activity
[dartdev, deps] Roll tools and share unified_analytics isBot check