-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-pkgUsed for miscellaneous pkg/ packages not associated with specific area- teams.Used for miscellaneous pkg/ packages not associated with specific area- teams.dds-dapDDS issues related to the Debug Adapter Protocol (DAP) implementationDDS issues related to the Debug Adapter Protocol (DAP) implementationpkg-ddsFor issues related to the Dart Development ServiceFor issues related to the Dart Development Service
Description
131fe7b updated how URIs are extracted from stack traces, introducing a new regular expression to detect URIs:
RegExp(r'([\w\-:\/\\%+]+\.dart)(?:(?:(?: +|:)(\d+):(\d+))|\W|$)')
However, this expression fails to account for some valid URIs, such as:
file:///private/var/folders/_y/rdj_3wtj5mbbtf6syy_2cw6800d8lv/T/flutter_flutter_adapter_test.6AkxWp/lib/main.dart:1:1
Which is incorrectly detected as due to . not being considered a valid character in a URI:
6AkxWp/lib/main.dart:1:1
Metadata
Metadata
Assignees
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-pkgUsed for miscellaneous pkg/ packages not associated with specific area- teams.Used for miscellaneous pkg/ packages not associated with specific area- teams.dds-dapDDS issues related to the Debug Adapter Protocol (DAP) implementationDDS issues related to the Debug Adapter Protocol (DAP) implementationpkg-ddsFor issues related to the Dart Development ServiceFor issues related to the Dart Development Service