prefer_const_constructors false positives in Flutter. #57615
Description
In the Flutter repo, prefer_const_constructors gives us a bunch of false positives (119). For example, in dart_picker.dart:
final Widget actions = new ButtonTheme.bar(
child: new ButtonBar(
children: <Widget>[
new FlatButton(
child: const Text('CANCEL'),
onPressed: _handleCancel,
),
new FlatButton(
child: const Text('OK'),
onPressed: _handleOk,
),
],
),
);
we report prefer_const_constructors on new ButtonBar, and then on the list of children: and then for onPressed: which cannot be const.
cc @ a14n @bwilkerson