-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.breaking-change-requestThis tracks requests for feedback on breaking changesThis tracks requests for feedback on breaking changeslibrary-iotriagedIssue has been triaged by sub teamIssue has been triaged by sub teamtype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug
Description
Change Intent
IOOverrides should be marked as base to prevent implementation of the class.
Justification
This class is used to override behavior of certain APIs in dart:io. There's no reason for developers to implement this class and marking it as base will allow for additional overrides to be added to the class without requiring a breaking change (e.g., [ dart:io ] Added override for exit(...) in IOOverrides).
Impact
Code implementing IOOverrides will no longer compile.
Mitigation
PRs should be sent to remove cases where IOOverrides is implemented, where possible. There's only a handful of cases found on GitHub.
Change Timeline
ASAP.
Associated CLs
sigurdm and kobdeep
Metadata
Metadata
Assignees
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.breaking-change-requestThis tracks requests for feedback on breaking changesThis tracks requests for feedback on breaking changeslibrary-iotriagedIssue has been triaged by sub teamIssue has been triaged by sub teamtype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug
Type
Projects
Status
Complete