Skip to content

[CP] [dart2wasm] Fix bug in setter type checker argument checking implementation #56374

@mkustermann

Description

@mkustermann

Commit(s) to merge

2cf3222

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/378860

Issue Description

Flutter code that uses dynamic calls where the dynamic call targets a setter with a generic argument will (in -O3 / -O4 mode - the ladder which is flutter builds default) sets null instead of the actual value.

What is the fix

Make compiler in -O3 / -O4 mode correctly set the field value in the implicit setter.

Why cherry-pick

Flutter users have hit this.

Risk

If tests pass: low

Issue link(s)

flutter/flutter#152029

Extra Info

No response

Metadata

Metadata

Labels

area-dart2wasmIssues for the dart2wasm compiler.cherry-pick-approvedLabel for approved cherrypick requestcherry-pick-mergedCherry-pick has been merged to the stable or beta branch.cherry-pick-reviewIssue that need cherry pick triage to approvetype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions