-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Closed
Copy link
Labels
area-dart2wasmIssues for the dart2wasm compiler.Issues for the dart2wasm compiler.cherry-pick-approvedLabel for approved cherrypick requestLabel for approved cherrypick requestcherry-pick-mergedCherry-pick has been merged to the stable or beta branch.Cherry-pick has been merged to the stable or beta branch.cherry-pick-reviewIssue that need cherry pick triage to approveIssue that need cherry pick triage to approvetype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)Incorrect behavior (everything from a crash to more subtle misbehavior)
Description
Commit(s) to merge
Target
stable
Prepared changelist for beta/stable
Issue Description
Flutter code that uses dynamic calls where the dynamic call targets a setter with a generic argument will (in -O3 / -O4 mode - the ladder which is flutter builds default) sets null instead of the actual value.
What is the fix
Make compiler in -O3 / -O4 mode correctly set the field value in the implicit setter.
Why cherry-pick
Flutter users have hit this.
Risk
If tests pass: low
Issue link(s)
Extra Info
No response
Metadata
Metadata
Assignees
Labels
area-dart2wasmIssues for the dart2wasm compiler.Issues for the dart2wasm compiler.cherry-pick-approvedLabel for approved cherrypick requestLabel for approved cherrypick requestcherry-pick-mergedCherry-pick has been merged to the stable or beta branch.Cherry-pick has been merged to the stable or beta branch.cherry-pick-reviewIssue that need cherry pick triage to approveIssue that need cherry pick triage to approvetype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)Incorrect behavior (everything from a crash to more subtle misbehavior)