-
Notifications
You must be signed in to change notification settings - Fork 1.8k
dartify doesn't convert Promises on dart2wasm #54573
Copy link
Copy link
Closed
Labels
area-dart2wasmIssues for the dart2wasm compiler.Issues for the dart2wasm compiler.area-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.web-js-interopIssues that impact all js interopIssues that impact all js interop
Metadata
Metadata
Assignees
Labels
area-dart2wasmIssues for the dart2wasm compiler.Issues for the dart2wasm compiler.area-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.web-js-interopIssues that impact all js interopIssues that impact all js interop
Type
Projects
Status
Done
dart:js_interop'sdartifydoesn't convertPromises toFutures on dart2wasm like dart2js/DDC. Instead it treats it like aJSValue:results in:
but passes on dart2js/DDC.
The culprit is
sdk/sdk/lib/_internal/wasm/lib/js_helper.dart
Line 422 in 9329f7b
Promises. DDC/dart2js does:sdk/sdk/lib/_internal/js_shared/lib/js_util_patch.dart
Line 596 in 9329f7b