-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.breaking-change-approvedbreaking-change-requestThis tracks requests for feedback on breaking changesThis tracks requests for feedback on breaking changesvm-native
Milestone
Description
The NativeWrapperClasses should be marked base so that none of their subtypes can be implemented.
Implementing subtypes can lead to issues when passing such native wrapper to a native call, as it will try to unwrap a native field that doesn't exist (likely leading to a segfault).
Flutter has classes which extend NativeWrapperClasses and are mocked in tests.
And Flutter has already opted in to 3.0, so adding the class modifiers to dart:nativewrappers is a breaking change for Flutter.
Metadata
Metadata
Assignees
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.breaking-change-approvedbreaking-change-requestThis tracks requests for feedback on breaking changesThis tracks requests for feedback on breaking changesvm-native
Type
Projects
Status
Complete