-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
P3A lower priority bug or feature requestA lower priority bug or feature requestdevexp-data-driven-fixesIssues with the analysis server's support for data-driven fixesIssues with the analysis server's support for data-driven fixeslegacy-area-analyzerUse area-devexp instead.Use area-devexp instead.type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)Incorrect behavior (everything from a crash to more subtle misbehavior)
Description
Noticed in flutter/flutter#119187
With this transform rule:
- title: "Migrate to 'routeInformationUpdated'"
date: 2023-01-30
element:
uris: [ 'services.dart' ]
method: 'routeUpdated'
inClass: 'SystemNavigator'
changes:
- kind: 'removeParameter'
name: 'previousRouteName'
- kind: 'renameParameter'
oldName: 'routeName'
newName: 'location'
- kind: 'rename'
newName: 'routeInformationUpdated'The expectation is that this will be the result:
/// Before, deprecated method
SystemNavigator.routeUpdated(routeName: 'foo', previousRouteName: 'bar');
/// After
SystemNavigator.routeInformationUpdated(location: 'foo');Instead the result is only a partial transformation:
/// Actual result
SystemNavigator.routeInformationUpdated(routeName: 'foo');Metadata
Metadata
Assignees
Labels
P3A lower priority bug or feature requestA lower priority bug or feature requestdevexp-data-driven-fixesIssues with the analysis server's support for data-driven fixesIssues with the analysis server's support for data-driven fixeslegacy-area-analyzerUse area-devexp instead.Use area-devexp instead.type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)Incorrect behavior (everything from a crash to more subtle misbehavior)