-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
google/grinder.dart
#374Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.library-io
Description
According to the documentation for CreateProcessW: " If you are using a long file name that contains a space, use quoted strings to indicate where the file name ends and the arguments begin; otherwise, the file name is ambiguous."
However, it looks like the current implementation for starting processes doesn't add the quotes.
As a result, if you try to run the program C:\Program Files\foo.exe and there is another file named C:\Program, Windows resolves the path as C:\Program, but since it isn't a valid Win32 program, then we get the error: "CreateProcessW failed 193: %1 is not a valid Win32 application".
Causes: flutter/flutter#19359
cc @zanderso
Metadata
Metadata
Assignees
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.library-io