-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Description
https://dart-review.googlesource.com/c/sdk/+/104286 caused a bunch of benchmark regressions. This was entirely due to the new implementation of dart::compiler::target::ClassTable::StateOffsetFor(intptr_t cid). Don't know why this caused such a huge performance regression, but I rolled back the culprit function in: https://dart-review.googlesource.com/c/sdk/+/105550
Need to investigate this more and then roll forward.
Metadata
Metadata
Assignees
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.