Skip to content

ClassTable::StateOffsetFor performance regression #37221

@liamappelbe

Description

@liamappelbe

https://dart-review.googlesource.com/c/sdk/+/104286 caused a bunch of benchmark regressions. This was entirely due to the new implementation of dart::compiler::target::ClassTable::StateOffsetFor(intptr_t cid). Don't know why this caused such a huge performance regression, but I rolled back the culprit function in: https://dart-review.googlesource.com/c/sdk/+/105550

Need to investigate this more and then roll forward.

Metadata

Metadata

Assignees

Labels

area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions