-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
P1A high priority bug; for example, a single project is unusable or has many test failuresA high priority bug; for example, a single project is unusable or has many test failuresweb-dev-compiler
Milestone
Description
Use the instructions and patches here to enable the constants flag: #36479
DDC's Kernel-backend compiled SDK will not load. I've found a few issues so far:
- the SDK's internal annotations are not found. For example
@nullCheck,@notNull,@JSExportName,@NoReifyGenerics, and probably other critical ones such as@JsPeerIterface. - static calls seem to be tagging the target with RTTI, as if it were a tearoff. As a result, we attempt to create a
dart.FunctionTypebefore it has been defined. This might partly be an issue with@ReifyFunctionTypes, but even so, we should not be reifying in these cases as it is unnecessary. We'll need to double check that this works properly for user code.
Also a few minor/trivial issues (not P1) such as:
- integer constants are generated as if they were doubles:
1.0instead of1. This is valid, but has a very slight code size/readability cost.
Metadata
Metadata
Assignees
Labels
P1A high priority bug; for example, a single project is unusable or has many test failuresA high priority bug; for example, a single project is unusable or has many test failuresweb-dev-compiler