Skip to content

when reporting for host for flutter_tools, we should report for 'CLI' host #34543

Closed

Description

@devoncarew

We report the host for flutter_tools runs - this is used to know which IDE is driving flutter_tools; we key off the value of the FLUTTER_HOST environment variable. It would be nice to also report a 'host' for pure CLI usage. We could infer this by there being no value set for FLUTTER_HOST, and for the entrypoint command into the tool not being the daemon command (or, flutter run --machine).

We should also update the docs for building tools on flutter_tools to specify that IDEs - and people driving flutter_tools - should specify an FLUTTER_HOST env variable.

cc @mit-mit

Activity

  1. vsmenon commented on Sep 24, 2018

    @vsmenon
    Member

    @devoncarew - is this an ask on the VM?

  2. devoncarew commented on Sep 24, 2018

    @devoncarew
    ContributorAuthor

    No, just a change to flutter_tools.

  3. vsmenon commented on Sep 24, 2018

    @vsmenon
    Member

    Shouldn't that be filed on the flutter repo then?

  4. devoncarew commented on Sep 24, 2018

    @devoncarew
    ContributorAuthor

    oops! I'd meant to.

  5. ghost deleted a comment from devoncarew on Sep 24, 2018
  6. ghost closed this as completedon Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions