Skip to content

patch_sdk tool must return non-zero error code if it reported any nits/warnings/errors #30127

@zanderso

Description

@zanderso

E.g.:

[4737/17343] ACTION //flutter/lib/snapshot:flutter_patched_sdk(//build/toolchain/fuchsia:x64)
Not enabling colors, stdout does not support ANSI colors.
flutter_patched_sdk/lib/ui/ui.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.

See GN guidelines here: https://github.com/dart-lang/sdk/wiki/Building-with-GN#hints-suggestions-etc

In particular: "A successful GN build produces no output."

/cc @sigmundch

Metadata

Metadata

Labels

customer-flutterlegacy-area-front-endLegacy: Use area-dart-model instead.type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions