The grammar change looks somewhat right, but I think there will be a few more rules around it. For example, I'm not sure you will be allowed to omit the type on a simple parameter if you write `covariant`, so it's probably going to be more like: metadata ('covariant' 'final'? type | finalConstVarOrType?) identifier That skirts the problem that `covariant` isn't a built-in identifier because it's never ambiguous whether it's used as a marker or as a type (which it never will be anyway, but the grammar must work even for unreasonable input). Likewise, I'm not sure you will be allowed to omit the return type from the function signature after a `covariant`. Finally, you should only be allowed to write `covariant` in instance method declarations. /L

…

On Wed, Dec 21, 2016 at 4:31 PM, sigmundch ***@***.***> wrote: Could you include here or add one last comment in #27486 <#27486> showing what the final syntax change looks like? That bug has lots of discussions and, from a quick glance it is not obvious what the final decision is. It seems like the very first comment on the thread was updated to reflect the final syntax you decided on, but I'm not 100% sure so I wanted to confirm. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#28165 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEo9B9B9sFB1Ts_LzFZipOmROSoO8V5Sks5rKUZcgaJpZM4LS7cf> .

-- Lasse R.H. Nielsen - lrn@google.com 'Faith without judgement merely degrades the spirit divine' Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K - Denmark - CVR nr. 28 86 69 84

Implement covariant marker in dart2js #28165

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Implement `covariant` marker in dart2js #28165