Change the wording of unused-element

bwilkerson · commit-bot@chromium.org · commit fe1da36f1255 · 2019-07-22T12:40:07.000Z
I think this makes the message better, but it also means that the message can be internationalized. Change-Id: I0697fc05b79e33d5af2424609b30c2832b1a210b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109860 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/dart/error/hint_codes.dart b/pkg/analyzer/lib/src/dart/error/hint_codes.dart
@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/error/error.dart';
-import 'package:analyzer/src/dart/element/element.dart';
 
 /**
  * The hints and coding recommendations for best practices which are not
@@ -839,11 +838,12 @@ class HintCode extends ErrorCode {
       correction: "Try removing the stack trace variable, or using it.");
 
   /**
-   * See [Modifier.IS_USED_IN_LIBRARY].
+   * Parameters:
+   * 0: The name that is declared but not referenced.
    */
   static const HintCode UNUSED_ELEMENT = const HintCode(
-      'UNUSED_ELEMENT', "The {0} '{1}' isn't used.",
-      correction: "Try removing the declaration of '{1}'.");
+      'UNUSED_ELEMENT', "The declaration '{0}' isn't referenced.",
+      correction: "Try removing the declaration of '{0}'.");
 
   /**
    * Unused fields are fields which are never read.
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -8543,8 +8543,8 @@ class UnusedLocalElementsVerifier extends RecursiveAstVisitor {
 
   _visitClassElement(ClassElement element) {
     if (!_isUsedElement(element)) {
-      _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,
-          [element.kind.displayName, element.displayName]);
+      _reportErrorForElement(
+          HintCode.UNUSED_ELEMENT, element, [element.displayName]);
     }
   }
 
@@ -8557,15 +8557,15 @@ class UnusedLocalElementsVerifier extends RecursiveAstVisitor {
 
   _visitFunctionElement(FunctionElement element) {
     if (!_isUsedElement(element)) {
-      _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,
-          [element.kind.displayName, element.displayName]);
+      _reportErrorForElement(
+          HintCode.UNUSED_ELEMENT, element, [element.displayName]);
     }
   }
 
   _visitFunctionTypeAliasElement(FunctionTypeAliasElement element) {
     if (!_isUsedElement(element)) {
-      _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,
-          [element.kind.displayName, element.displayName]);
+      _reportErrorForElement(
+          HintCode.UNUSED_ELEMENT, element, [element.displayName]);
     }
   }
 
@@ -8585,22 +8585,22 @@ class UnusedLocalElementsVerifier extends RecursiveAstVisitor {
 
   _visitMethodElement(MethodElement element) {
     if (!_isUsedMember(element)) {
-      _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,
-          [element.kind.displayName, element.displayName]);
+      _reportErrorForElement(
+          HintCode.UNUSED_ELEMENT, element, [element.displayName]);
     }
   }
 
   _visitPropertyAccessorElement(PropertyAccessorElement element) {
     if (!_isUsedMember(element)) {
-      _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,
-          [element.kind.displayName, element.displayName]);
+      _reportErrorForElement(
+          HintCode.UNUSED_ELEMENT, element, [element.displayName]);
     }
   }
 
   _visitTopLevelVariableElement(TopLevelVariableElement element) {
     if (!_isUsedElement(element)) {
-      _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,
-          [element.kind.displayName, element.displayName]);
+      _reportErrorForElement(
+          HintCode.UNUSED_ELEMENT, element, [element.displayName]);
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -8543,8 +8543,8 @@ class UnusedLocalElementsVerifier extends RecursiveAstVisitor {`
`8543`	`8543`
`8544`	`8544`	`_visitClassElement(ClassElement element) {`
`8545`	`8545`	`if (!_isUsedElement(element)) {`
`8546`		`- _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,`
`8547`		`- [element.kind.displayName, element.displayName]);`
	`8546`	`+ _reportErrorForElement(`
	`8547`	`+ HintCode.UNUSED_ELEMENT, element, [element.displayName]);`
`8548`	`8548`	`}`
`8549`	`8549`	`}`
`8550`	`8550`
`@@ -8557,15 +8557,15 @@ class UnusedLocalElementsVerifier extends RecursiveAstVisitor {`
`8557`	`8557`
`8558`	`8558`	`_visitFunctionElement(FunctionElement element) {`
`8559`	`8559`	`if (!_isUsedElement(element)) {`
`8560`		`- _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,`
`8561`		`- [element.kind.displayName, element.displayName]);`
	`8560`	`+ _reportErrorForElement(`
	`8561`	`+ HintCode.UNUSED_ELEMENT, element, [element.displayName]);`
`8562`	`8562`	`}`
`8563`	`8563`	`}`
`8564`	`8564`
`8565`	`8565`	`_visitFunctionTypeAliasElement(FunctionTypeAliasElement element) {`
`8566`	`8566`	`if (!_isUsedElement(element)) {`
`8567`		`- _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,`
`8568`		`- [element.kind.displayName, element.displayName]);`
	`8567`	`+ _reportErrorForElement(`
	`8568`	`+ HintCode.UNUSED_ELEMENT, element, [element.displayName]);`
`8569`	`8569`	`}`
`8570`	`8570`	`}`
`8571`	`8571`
`@@ -8585,22 +8585,22 @@ class UnusedLocalElementsVerifier extends RecursiveAstVisitor {`
`8585`	`8585`
`8586`	`8586`	`_visitMethodElement(MethodElement element) {`
`8587`	`8587`	`if (!_isUsedMember(element)) {`
`8588`		`- _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,`
`8589`		`- [element.kind.displayName, element.displayName]);`
	`8588`	`+ _reportErrorForElement(`
	`8589`	`+ HintCode.UNUSED_ELEMENT, element, [element.displayName]);`
`8590`	`8590`	`}`
`8591`	`8591`	`}`
`8592`	`8592`
`8593`	`8593`	`_visitPropertyAccessorElement(PropertyAccessorElement element) {`
`8594`	`8594`	`if (!_isUsedMember(element)) {`
`8595`		`- _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,`
`8596`		`- [element.kind.displayName, element.displayName]);`
	`8595`	`+ _reportErrorForElement(`
	`8596`	`+ HintCode.UNUSED_ELEMENT, element, [element.displayName]);`
`8597`	`8597`	`}`
`8598`	`8598`	`}`
`8599`	`8599`
`8600`	`8600`	`_visitTopLevelVariableElement(TopLevelVariableElement element) {`
`8601`	`8601`	`if (!_isUsedElement(element)) {`
`8602`		`- _reportErrorForElement(HintCode.UNUSED_ELEMENT, element,`
`8603`		`- [element.kind.displayName, element.displayName]);`
	`8602`	`+ _reportErrorForElement(`
	`8603`	`+ HintCode.UNUSED_ELEMENT, element, [element.displayName]);`
`8604`	`8604`	`}`
`8605`	`8605`	`}`
`8606`	`8606`	`}`