[vm] Switchable calls ignore functions being stepping or having breakpoints

zichangg · commit-bot@chromium.org · commit fa45f91f18cb · 2019-08-07T15:28:11.000Z
Switchable calls should exclude functions that either are under stepping or have breakpoints Bug: #37747 (comment) Change-Id: I9d71c0ee0b9086b43d9a98bf0719196a081f070d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112147 Commit-Queue: Zichang Guo <zichangguo@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
diff --git a/runtime/vm/runtime_entry.cc b/runtime/vm/runtime_entry.cc
@@ -1121,6 +1121,11 @@ static void TrySwitchInstanceCall(const ICData& ic_data,
   if (caller_function.unoptimized_code() != caller_code.raw()) {
     return;
   }
+#if !defined(PRODUCT)
+  // Skip functions that contain breakpoints or when debugger is in single
+  // stepping mode.
+  if (Debugger::IsDebugging(thread, caller_function)) return;
+#endif
 
   intptr_t num_checks = ic_data.NumberOfChecks();
 
