[analyzer] enable implicit-casts: false for several projects

devoncarew · commit-bot@chromium.org · commit f53388b50dbc · 2019-08-13T16:26:41.000Z
Change-Id: Idd7ed77756d93a94f637dcc4abd7e0403a2f6d81 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112703 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analysis_server/analysis_options.yaml b/pkg/analysis_server/analysis_options.yaml
@@ -1,4 +1,7 @@
 analyzer:
+  # This currently finds ~1,200 implicit-casts issues when enabled.
+  # strong-mode:
+  #   implicit-casts: false
   exclude:
     - test/mock_packages/**
 
diff --git a/pkg/analysis_server_client/analysis_options.yaml b/pkg/analysis_server_client/analysis_options.yaml
@@ -0,0 +1,10 @@
+analyzer:
+  #strong-mode:
+  #  implicit-casts: false
+
+linter:
+  rules:
+    - empty_constructor_bodies
+    - empty_statements
+    - unnecessary_brace_in_string_interps
+    - valid_regexps
diff --git a/pkg/analysis_server_client/example/example.dart b/pkg/analysis_server_client/example/example.dart
@@ -99,7 +99,7 @@ class _Handler with NotificationHandler, ConnectionHandler {
       if (errorCount == 0) {
         print('No issues found.');
       } else {
-        print('Found ${errorCount} errors/warnings/hints');
+        print('Found $errorCount errors/warnings/hints');
       }
       errorCount = 0;
       print('--------- ctrl-c to exit ---------');
diff --git a/pkg/analysis_server_client/lib/src/protocol/protocol_util.dart b/pkg/analysis_server_client/lib/src/protocol/protocol_util.dart
@@ -32,13 +32,14 @@ class JenkinsSmiHash {
   }
 
   /// Combines together two hash codes.
-  static int hash2(a, b) => finish(combine(combine(0, a), b));
+  static int hash2(int a, int b) => finish(combine(combine(0, a), b));
 
   /// Combines together three hash codes.
-  static int hash3(a, b, c) => finish(combine(combine(combine(0, a), b), c));
+  static int hash3(int a, int b, int c) =>
+      finish(combine(combine(combine(0, a), b), c));
 
   /// Combines together four hash codes.
-  static int hash4(a, b, c, d) =>
+  static int hash4(int a, int b, int c, int d) =>
       finish(combine(combine(combine(combine(0, a), b), c), d));
 
   int _hash = 0;
diff --git a/pkg/analysis_tool/analysis_options.yaml b/pkg/analysis_tool/analysis_options.yaml
@@ -0,0 +1,10 @@
+analyzer:
+  strong-mode:
+    implicit-casts: false
+
+linter:
+  rules:
+    - empty_constructor_bodies
+    - empty_statements
+    - unnecessary_brace_in_string_interps
+    - valid_regexps
diff --git a/pkg/analyzer/analysis_options.yaml b/pkg/analyzer/analysis_options.yaml
@@ -1,3 +1,8 @@
+analyzer:
+  # This currently finds ~4,500 implicit-casts issues when enabled.
+  # strong-mode:
+  #   implicit-casts: false
+
 linter:
   rules:
     - empty_constructor_bodies # pedantic
diff --git a/pkg/analyzer/lib/src/dart/element/wrapped.dart b/pkg/analyzer/lib/src/dart/element/wrapped.dart
@@ -194,8 +194,10 @@ class WrappedCompilationUnitElement implements CompilationUnitElement {
       .accept(visitor); // ignore: deprecated_member_use_from_same_package
 
   @override
-  String computeDocumentationComment() =>
-      wrappedUnit.computeDocumentationComment();
+  String computeDocumentationComment() {
+    // ignore: deprecated_member_use_from_same_package
+    return wrappedUnit.computeDocumentationComment();
+  }
 
   @deprecated
   @override
diff --git a/pkg/dartfix/analysis_options.yaml b/pkg/dartfix/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:pedantic/analysis_options.1.8.0.yaml
 
+analyzer:
+  strong-mode:
+    implicit-casts: false
+
 linter:
   rules:
     directives_ordering: true
diff --git a/pkg/dartfix/lib/src/options.dart b/pkg/dartfix/lib/src/options.dart
@@ -52,7 +52,7 @@ class Options {
         pedanticFixes = results[pedanticOption] as bool,
         requiredFixes = results[requiredOption] as bool,
         sdkPath = _getSdkPath(),
-        serverSnapshot = results[_serverSnapshot],
+        serverSnapshot = results[_serverSnapshot] as String,
         showHelp = results[_helpOption] as bool || results.arguments.isEmpty,
         targets = results.rest,
         useColor = results.wasParsed(_colorOption)

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ class _Handler with NotificationHandler, ConnectionHandler {`
`99`	`99`	`if (errorCount == 0) {`
`100`	`100`	`print('No issues found.');`
`101`	`101`	`} else {`
`102`		`- print('Found ${errorCount} errors/warnings/hints');`
	`102`	`+ print('Found $errorCount errors/warnings/hints');`
`103`	`103`	`}`
`104`	`104`	`errorCount = 0;`
`105`	`105`	`print('--------- ctrl-c to exit ---------');`