Repository navigation
Commit eb5d798
[ffi] Separate native asset presence from loading
A null handle may be valid, so dlopen_v2 cannot distinguish a missing
asset from a load failure.
Replace it with contains_asset and dlopen_asset. Missing @Native assets
fall back; codeAsset misses and loader errors stay fatal.
Supersedes https://dart-review.googlesource.com/c/sdk/+/521960
TEST=Five focused run_vm_tests cases
TEST=tools/test.py -n vm-linux-debug-x64 ffi/native_assets
TEST=tools/test.py -n vm-aot-linux-debug-x64 ffi/native_assets
[email protected]
Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try,vm-gcc-linux-debug-x64-try,vm-win-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-tsan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-msvc-win-debug-x64-try,vm-msan-linux-release-x64-try,vm-mac-debug-x64-try,vm-linux-release-x64-try,vm-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-appjit-linux-debug-x64-try,vm-aot-win-debug-x64-try,vm-aot-mac-debug-x64-try,vm-aot-dwarf-linux-product-x64-try,vm-aot-android-debug-x64c-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-win-release-arm64-try,pkg-win-release-try,flutter-linux-try,flutter-mac-try
Change-Id: I09e9ff7833b712e7f22ed40325d5815d988c8769
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/533620
Reviewed-by: Daco Harkes <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>1 parent 41fa766 commit eb5d798
3 files changed
Lines changed: 306 additions & 62 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3350 | 3350 | | |
3351 | 3351 | | |
3352 | 3352 | | |
3353 | | - | |
3354 | | - | |
| 3353 | + | |
| 3354 | + | |
3355 | 3355 | | |
3356 | | - | |
| 3356 | + | |
3357 | 3357 | | |
3358 | 3358 | | |
3359 | | - | |
3360 | | - | |
3361 | | - | |
3362 | | - | |
3363 | | - | |
3364 | | - | |
| 3359 | + | |
| 3360 | + | |
3365 | 3361 | | |
3366 | 3362 | | |
3367 | 3363 | | |
| |||
3372 | 3368 | | |
3373 | 3369 | | |
3374 | 3370 | | |
| 3371 | + | |
| 3372 | + | |
| 3373 | + | |
| 3374 | + | |
| 3375 | + | |
| 3376 | + | |
| 3377 | + | |
| 3378 | + | |
| 3379 | + | |
| 3380 | + | |
| 3381 | + | |
| 3382 | + | |
| 3383 | + | |
| 3384 | + | |
3375 | 3385 | | |
3376 | 3386 | | |
3377 | 3387 | | |
| |||
3424 | 3434 | | |
3425 | 3435 | | |
3426 | 3436 | | |
| 3437 | + | |
| 3438 | + | |
| 3439 | + | |
| 3440 | + | |
| 3441 | + | |
| 3442 | + | |
| 3443 | + | |
| 3444 | + | |
| 3445 | + | |
| 3446 | + | |
3427 | 3447 | | |
3428 | 3448 | | |
3429 | 3449 | | |
3430 | 3450 | | |
3431 | | - | |
| 3451 | + | |
| 3452 | + | |
| 3453 | + | |
| 3454 | + | |
| 3455 | + | |
| 3456 | + | |
| 3457 | + | |
| 3458 | + | |
| 3459 | + | |
| 3460 | + | |
| 3461 | + | |
| 3462 | + | |
| 3463 | + | |
| 3464 | + | |
| 3465 | + | |
| 3466 | + | |
| 3467 | + | |
3432 | 3468 | | |
3433 | | - | |
3434 | | - | |
3435 | | - | |
| 3469 | + | |
| 3470 | + | |
3436 | 3471 | | |
3437 | | - | |
| 3472 | + | |
3438 | 3473 | | |
3439 | 3474 | | |
3440 | 3475 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | | - | |
378 | 377 | | |
379 | 378 | | |
380 | | - | |
381 | 379 | | |
382 | 380 | | |
383 | 381 | | |
| |||
394 | 392 | | |
395 | 393 | | |
396 | 394 | | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
| 395 | + | |
401 | 396 | | |
402 | 397 | | |
403 | 398 | | |
| |||
457 | 452 | | |
458 | 453 | | |
459 | 454 | | |
460 | | - | |
461 | | - | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
462 | 489 | | |
463 | 490 | | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
469 | | - | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
470 | 494 | | |
471 | 495 | | |
472 | 496 | | |
473 | | - | |
| 497 | + | |
474 | 498 | | |
475 | 499 | | |
476 | | - | |
477 | | - | |
| 500 | + | |
478 | 501 | | |
479 | 502 | | |
480 | 503 | | |
481 | | - | |
482 | | - | |
483 | | - | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
498 | | - | |
499 | | - | |
500 | 504 | | |
501 | 505 | | |
502 | 506 | | |
| |||
505 | 509 | | |
506 | 510 | | |
507 | 511 | | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | 512 | | |
514 | 513 | | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
515 | 541 | | |
516 | 542 | | |
517 | 543 | | |
| |||
521 | 547 | | |
522 | 548 | | |
523 | 549 | | |
524 | | - | |
525 | | - | |
526 | | - | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
527 | 560 | | |
528 | 561 | | |
529 | 562 | | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | 563 | | |
534 | 564 | | |
535 | | - | |
| 565 | + | |
536 | 566 | | |
537 | 567 | | |
538 | 568 | | |
| |||
546 | 576 | | |
547 | 577 | | |
548 | 578 | | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
549 | 586 | | |
550 | 587 | | |
551 | 588 | | |
| |||
0 commit comments