Skip to content

Commit e8880fd

Browse files
stereotype441commit-bot@chromium.org
authored andcommitted
Fix handling of unary- in the analyzer/FE comparison tool.
Drops the number of failing language_2 tests with `--compiler compare_analyzer_cfe` from 34 to 22. Change-Id: I1d35d0ac11816d29a5f3044db81a5c24e1b25477 Reviewed-on: https://dart-review.googlesource.com/75129 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent bd103eb commit e8880fd

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/analyzer_fe_comparison/lib/src/analyzer.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,17 @@ class _AnalyzerVisitor extends UnifyingAstVisitor<void> {
174174

175175
@override
176176
void visitMethodDeclaration(MethodDeclaration node) {
177+
var name = node.name.name;
177178
String kind;
178179
if (node.isGetter) {
179180
kind = 'Getter';
180181
} else if (node.isSetter) {
181182
kind = 'Setter';
182183
} else if (node.isOperator) {
183184
kind = 'Operator';
185+
if (name == '-' && node.declaredElement.parameters.isEmpty) {
186+
name = 'unary-';
187+
}
184188
} else {
185189
kind = 'Method';
186190
}
@@ -190,8 +194,7 @@ class _AnalyzerVisitor extends UnifyingAstVisitor<void> {
190194
visitor._visitParameters(node.parameters);
191195
children
192196
.add(_translateType('Return type: ', node.declaredElement.returnType));
193-
_resultNodes
194-
.add(ComparisonNode.sorted('$kind ${node.name.name}', children));
197+
_resultNodes.add(ComparisonNode.sorted('$kind $name', children));
195198
}
196199

197200
@override

0 commit comments

Comments
 (0)