Check more in LegacyTypeAsserter.

scheglov · commit-bot@chromium.org · commit e3aac9e25df0 · 2019-11-08T17:00:07.000Z
Change-Id: Ie90ff509dd4327ef33a1ce7fb81657ff8c2f1412 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124500 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/analyzer/lib/src/dart/resolver/legacy_type_asserter.dart b/pkg/analyzer/lib/src/dart/resolver/legacy_type_asserter.dart
@@ -74,6 +74,7 @@ class LegacyTypeAsserter extends GeneralizingAstVisitor {
   @override
   visitExpression(Expression e) {
     _assertLegacyType(e.staticType);
+    _assertLegacyType(e.staticParameterElement?.type);
     super.visitExpression(e);
   }
 
@@ -89,6 +90,13 @@ class LegacyTypeAsserter extends GeneralizingAstVisitor {
     super.visitFunctionDeclaration(node);
   }
 
+  @override
+  visitInvocationExpression(InvocationExpression node) {
+    _assertLegacyType(node.staticInvokeType);
+    node.typeArgumentTypes?.forEach(_assertLegacyType);
+    return super.visitInvocationExpression(node);
+  }
+
   @override
   visitTypeAnnotation(TypeAnnotation node) {
     _assertLegacyType(node.type);
diff --git a/pkg/analyzer/test/src/diagnostics/default_list_constructor_mismatch_test.dart b/pkg/analyzer/test/src/diagnostics/default_list_constructor_mismatch_test.dart
@@ -51,6 +51,9 @@ var l = new List<String?>(3);
 ''');
   }
 
+  @FailingTest(
+    reason: 'The type of the parameterElement for `3` is non-nullable',
+  )
   test_optOut() async {
     await assertNoErrorsInCode('''
 // @dart = 2.2

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ var l = new List<String?>(3);`
`51`	`51`	`''');`
`52`	`52`	`}`
`53`	`53`
	`54`	`+ @FailingTest(`
	`55`	+ reason: 'The type of the parameterElement for `3` is non-nullable',
	`56`	`+ )`
`54`	`57`	`test_optOut() async {`
`55`	`58`	`await assertNoErrorsInCode('''`
`56`	`59`	`// @dart = 2.2`