Fix a bug in constructor element display string (issue 37165)

bwilkerson · commit-bot@chromium.org · commit da66902e4f6f · 2019-06-07T13:21:59.000Z
Change-Id: Ie5fe3b5c4e78be67887cf56e4698554d44095fd0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105349 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -2725,12 +2725,12 @@ class ConstructorElementImpl extends ExecutableElementImpl
   @override
   void appendTo(StringBuffer buffer) {
     String name;
+    String constructorName = displayName;
     if (enclosingElement == null) {
       String message;
-      String name = displayName;
-      if (name != null && !name.isEmpty) {
+      if (constructorName != null && !constructorName.isEmpty) {
         message =
-            'Found constructor element named $name with no enclosing element';
+            'Found constructor element named $constructorName with no enclosing element';
       } else {
         message = 'Found unnamed constructor element with no enclosing element';
       }
@@ -2739,7 +2739,6 @@ class ConstructorElementImpl extends ExecutableElementImpl
     } else {
       name = enclosingElement.displayName;
     }
-    String constructorName = displayName;
     if (constructorName != null && !constructorName.isEmpty) {
       name = '$name.$constructorName';
     }
