[vm/bytecode] Remove DebugCheck in synthetic non-local transfer (no source pos).

crelier · commit-bot@chromium.org · commit d57a8f745126 · 2019-08-28T22:32:31.000Z
This fixes the following test: service/async_star_step_out_test Change-Id: I5def5fd277dcc4d32838c6ddb225441ece45e71f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114751 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Régis Crelier <regis@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
diff --git a/pkg/vm/lib/bytecode/gen_bytecode.dart b/pkg/vm/lib/bytecode/gen_bytecode.dart
@@ -2417,7 +2417,7 @@ class BytecodeGenerator extends RecursiveVisitor<Null> {
   /// the last finally block.
   void _generateNonLocalControlTransfer(
       TreeNode from, TreeNode to, GenerateContinuation continuation) {
-    if (options.emitDebuggerStops) {
+    if (options.emitDebuggerStops && from.fileOffset != TreeNode.noOffset) {
       asm.emitDebugCheck(); // Before context is unwound.
     }
     List<TryFinally> tryFinallyBlocks = _getEnclosingTryFinallyBlocks(from, to);

Original file line number	Diff line number	Diff line change
`@@ -2417,7 +2417,7 @@ class BytecodeGenerator extends RecursiveVisitor<Null> {`
`2417`	`2417`	`/// the last finally block.`
`2418`	`2418`	`void _generateNonLocalControlTransfer(`
`2419`	`2419`	`TreeNode from, TreeNode to, GenerateContinuation continuation) {`
`2420`		`- if (options.emitDebuggerStops) {`
	`2420`	`+ if (options.emitDebuggerStops && from.fileOffset != TreeNode.noOffset) {`
`2421`	`2421`	`asm.emitDebugCheck(); // Before context is unwound.`
`2422`	`2422`	`}`
`2423`	`2423`	`List<TryFinally> tryFinallyBlocks = _getEnclosingTryFinallyBlocks(from, to);`