Corrections to "[vm] Fix ASAN build."

sjindel-google · commit-bot@chromium.org · commit d2dc05375231 · 2019-09-05T20:50:32.000Z
Change-Id: I83c78b18e25847edb6c8cc8256245667f1483619 Cq-Include-Trybots: luci.dart.try:vm-kernel-asan-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115711 Commit-Queue: Samir Jindel <sjindel@google.com> Auto-Submit: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
diff --git a/build/config/linux/BUILD.gn b/build/config/linux/BUILD.gn
@@ -5,17 +5,20 @@
 import("//build/config/sysroot.gni")
 
 config("sdk") {
-  ldflags = []
+  # Don't allow visible symbols from libc++ to be re-exported.
+  ldflags = [
+    "-nodefaultlibs",
+    "-lc++",
+    "-lc",
+    "-lm",
+    "-lclang_rt.builtins",
+    "-Wl,--exclude-libs=libc++.a",
+  ]
 
-  if (!is_asan) {
-    # Don't allow visible symbols from libc++ to be re-exported.
-    ldflags = [
-      "-nodefaultlibs",
-      "-lc++",
-      "-lc",
-      "-lm",
-      "-lclang_rt.builtins",
-      "-Wl,--exclude-libs=libc++.a",
+  if (is_asan) {
+    ldflags += [
+      "-lpthread",
+      "-lrt",
     ]
   }
 
