Skip to content

Commit d2bd969

Browse files
alexmarkovcommit-bot@chromium.org
authored andcommitted
[vm] Remove unused Resolver::ResolveStaticAllowPrivate
Change-Id: I31701f73b32371a61f5bf159be61d5ed2806bef8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137848 Reviewed-by: Régis Crelier <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
1 parent 7f483c0 commit d2bd969

File tree

2 files changed

+0
-40
lines changed

2 files changed

+0
-40
lines changed

runtime/vm/resolver.cc

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -219,36 +219,4 @@ RawFunction* Resolver::ResolveStatic(const Class& cls,
219219
return function.raw();
220220
}
221221

222-
RawFunction* Resolver::ResolveStaticAllowPrivate(const Class& cls,
223-
const String& function_name,
224-
intptr_t type_args_len,
225-
intptr_t num_arguments,
226-
const Array& argument_names) {
227-
ASSERT(!cls.IsNull());
228-
if (FLAG_trace_resolving) {
229-
THR_Print("ResolveStaticAllowPrivate '%s'\n", function_name.ToCString());
230-
}
231-
const Function& function =
232-
Function::Handle(cls.LookupStaticFunctionAllowPrivate(function_name));
233-
if (function.IsNull() ||
234-
!function.AreValidArguments(NNBDMode::kLegacyLib, type_args_len,
235-
num_arguments, argument_names, NULL)) {
236-
// Return a null function to signal to the upper levels to throw a
237-
// resolution error or maybe throw the error right here.
238-
if (FLAG_trace_resolving) {
239-
String& error_message = String::Handle(String::New("function not found"));
240-
if (!function.IsNull()) {
241-
// Obtain more detailed error message.
242-
function.AreValidArguments(NNBDMode::kLegacyLib, type_args_len,
243-
num_arguments, argument_names,
244-
&error_message);
245-
}
246-
THR_Print("ResolveStaticAllowPrivate error '%s': %s.\n",
247-
function_name.ToCString(), error_message.ToCString());
248-
}
249-
return Function::null();
250-
}
251-
return function.raw();
252-
}
253-
254222
} // namespace dart

runtime/vm/resolver.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,6 @@ class Resolver : public AllStatic {
6060
intptr_t type_args_len,
6161
intptr_t num_arguments,
6262
const Array& argument_names);
63-
64-
// Resolve specified dart static function with specified arity. Resolves both
65-
// public and private functions.
66-
static RawFunction* ResolveStaticAllowPrivate(const Class& cls,
67-
const String& function_name,
68-
intptr_t type_args_len,
69-
intptr_t num_arguments,
70-
const Array& argument_names);
7163
};
7264

7365
} // namespace dart

0 commit comments

Comments
 (0)