Skip to content

Commit c4bfca9

Browse files
bkonyicommit-bot@chromium.org
authored andcommitted
[ dart:io / package:vm_service ] Add HTTP request profiling service
extensions This change adds HTTP request profiling support to the dart:io service extensions and removes HTTP request/response body logging to the timeline due to memory constraints. Fixes #44950 TEST=pkg/vm_service/test/get_http_profile_test.dart Change-Id: I85642296c3d6595197f3365022477c7685c452bf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189881 Commit-Queue: Ben Konyi <[email protected]> Reviewed-by: Kenzie Schmoll <[email protected]>
1 parent 0c258ed commit c4bfca9

13 files changed

Lines changed: 1805 additions & 193 deletions

File tree

‎.dart_tool/package_config.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -739,6 +739,12 @@
739739
"packageUri": "lib/",
740740
"languageVersion": "2.12"
741741
},
742+
{
743+
"name": "uuid",
744+
"rootUri": "../third_party/pkg/uuid",
745+
"packageUri": "lib/",
746+
"languageVersion": "2.0"
747+
},
742748
{
743749
"name": "vector_math",
744750
"rootUri": "../third_party/pkg/vector_math",

‎pkg/compiler/test/analyses/api_allowed.json‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,15 +172,19 @@
172172
"Dynamic invocation of 'toLowerCase'.": 1
173173
},
174174
"org-dartlang-sdk:///lib/_http/http_impl.dart": {
175+
"Dynamic access of 'headers'.": 1,
176+
"Dynamic invocation of 'forEach'.": 1,
177+
"Dynamic access of 'connectionInfo'.": 4,
178+
"Dynamic access of 'localPort'.": 1,
179+
"Dynamic access of 'remoteAddress'.": 2,
180+
"Dynamic access of 'address'.": 3,
181+
"Dynamic access of 'remotePort'.": 2,
175182
"Dynamic access of 'message'.": 3,
176183
"Dynamic invocation of 'call'.": 1,
177184
"Dynamic invocation of 'destroy'.": 2,
178185
"Dynamic invocation of 'setOption'.": 1,
179-
"Dynamic access of 'address'.": 2,
180186
"Dynamic access of 'host'.": 2,
181187
"Dynamic access of 'port'.": 2,
182-
"Dynamic access of 'remoteAddress'.": 1,
183-
"Dynamic access of 'remotePort'.": 1,
184188
"Dynamic invocation of 'dart._http::_toJSON'.": 3,
185189
"Dynamic invocation of 'listen'.": 1,
186190
"Dynamic invocation of 'close'.": 1

‎pkg/vm_service/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
# Changelog
2+
3+
## 6.2.0
4+
- Added support for `getHttpProfile` and `clearHttpProfile` `dart:io` service extensions.
5+
26
## 6.1.1
37
- Callsite `StackTrace`s are now attached to `RPCError`s and `SentinelException`s.
48
- Added `identityHashCode` property to `InstanceRef` and `Instance`.

0 commit comments

Comments
 (0)