[vm] Disable inlining of _StringBase._createOneByteString

alexmarkov · commit-bot@chromium.org · commit c0d1dedd786d · 2019-08-12T17:56:05.000Z
If _StringBase._createOneByteString is inlined it becomes much slower due to #37800. This workaround improves Base64Encoder benchmark on ia32 in bytecode mode: Base64Encoder(RunTime): 63.31 -> 46.7 us. Issue: #37800 Change-Id: Ibcf5dc7bfd25bac0bd61a9dcb196c553c82f3dc1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112647 Reviewed-by: Aart Bik <ajcbik@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
diff --git a/runtime/lib/string_patch.dart b/runtime/lib/string_patch.dart
@@ -219,6 +219,8 @@ abstract class _StringBase implements String {
     return createFromCharCodes(charCodeList, 0, length, bits);
   }
 
+  // Inlining is disabled as a workaround to http://dartbug.com/37800.
+  @pragma("vm:never-inline")
   static String _createOneByteString(List<int> charCodes, int start, int len) {
     // It's always faster to do this in Dart than to call into the runtime.
     var s = _OneByteString._allocate(len);

Original file line number	Diff line number	Diff line change
`@@ -219,6 +219,8 @@ abstract class _StringBase implements String {`
`219`	`219`	`return createFromCharCodes(charCodeList, 0, length, bits);`
`220`	`220`	`}`
`221`	`221`
	`222`	`+ // Inlining is disabled as a workaround to http://dartbug.com/37800.`
	`223`	`+ @pragma("vm:never-inline")`
`222`	`224`	`static String _createOneByteString(List<int> charCodes, int start, int len) {`
`223`	`225`	`// It's always faster to do this in Dart than to call into the runtime.`
`224`	`226`	`var s = _OneByteString._allocate(len);`