Improve a diagnostic message by adding specific type information

bwilkerson · commit-bot@chromium.org · commit ae5d4973abf6 · 2019-07-23T13:55:11.000Z
Also, re-enable some tests that were unintentionally commented out. Change-Id: I88ee5cf690c6c7132d80becae6952add229eba47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109983 Reviewed-by: Phil Quitslund <pquitslund@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/error/codes.dart b/pkg/analyzer/lib/src/error/codes.dart
@@ -1237,13 +1237,15 @@ class CompileTimeErrorCode extends ErrorCode {
           correction: "Try using just the name of the extension.");
 
   /**
-   * No parameters.
+   * Parameters:
+   * 0: the type of the argument
+   * 1: the extended type
    */
   static const CompileTimeErrorCode EXTENSION_OVERRIDE_ARGUMENT_NOT_ASSIGNABLE =
       const CompileTimeErrorCode(
           'EXTENSION_OVERRIDE_ARGUMENT_NOT_ASSIGNABLE',
-          "The argument to the extension override is not assignable to the "
-              "extended type.");
+          "The type of the argument to the extension override '{0}' "
+              "is not assignable to the extended type '{1}'.");
 
   /**
    * 12.14.2 Binding Actuals to Formals: It is a static warning if <i>m &lt;
diff --git a/pkg/analyzer/test/src/diagnostics/extension_override_argument_not_assignable_test.dart b/pkg/analyzer/test/src/diagnostics/extension_override_argument_not_assignable_test.dart
@@ -11,7 +11,7 @@ import '../dart/resolution/driver_resolution.dart';
 
 main() {
   defineReflectiveSuite(() {
-//    defineReflectiveTests(ExtensionDeclaresAbstractMethodTest);
+    defineReflectiveTests(ExtensionDeclaresAbstractMethodTest);
     defineReflectiveTests(ExtensionDeclaresAbstractMethodWithNNBDTest);
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ import '../dart/resolution/driver_resolution.dart';`
`11`	`11`
`12`	`12`	`main() {`
`13`	`13`	`defineReflectiveSuite(() {`
`14`		`-// defineReflectiveTests(ExtensionDeclaresAbstractMethodTest);`
	`14`	`+ defineReflectiveTests(ExtensionDeclaresAbstractMethodTest);`
`15`	`15`	`defineReflectiveTests(ExtensionDeclaresAbstractMethodWithNNBDTest);`
`16`	`16`	`});`
`17`	`17`	`}`